Re: [PATCH 15/27] memory: tegra: remove MODULE_LICENSE in non-modules

Nick Alcock
2023-03-06T19:05:01Z

On 6 Mar 2023, Krzysztof Kozlowski told this:

> On 06/03/2023 15:30, Krzysztof Kozlowski wrote:
>> On 24/02/2023 16:07, Nick Alcock wrote:
>>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>>> are used to identify modules. As a consequence, uses of the macro
>>> in non-modules will cause modprobe to misidentify their containing
>>> object file as a module when it is not (false positives), and modprobe
>>> might succeed rather than failing with a suitable error message.
>>>
>>> So remove it in the files in this commit, none of which can be built as
>>> modules.
>>
>> Applied as well. Squashed with next one. Same subject messes with b4, so
>> prefix should be corrected if these were to stay as separate patches.
>
> And all dropped. Run checkpatch before sending patches.

So... which of the 27 patches n this series is being dropped? It would
also be nice to know what the checkpatch problems were, because all I
can see from checkpatch is one error per patch, an apparent false
positive:

ERROR: Please use git commit description style 'commit <12+ chars of sha1> (" ")' - ie: 'commit 8b41fc4454e3 ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf")'

The commit message says:

> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations

... which unless I am seeing things is precisely what checkpatch.pl is
asking for. Perhaps it can't handle wrapped lines, but not wrapping a
git commit log line *also* (correctly) elicits a checkpatch error...