Re: [PATCH 04/27] mfd: intel_soc_pmic_crc: remove MODULE_LICENSE in non-modules

Andy Shevchenko
2023-02-24T16:40:01Z

On Fri, Feb 24, 2023 at 03:07:48PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>

> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Andy Shevchenko <andy@kernel.org>
> Cc: Lee Jones <lee@kernel.org>

Please, use --cc parameter instead of polluting commit message.

With this addressed,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index b1548a933dc3..b745ace46e5b 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -271,6 +271,5 @@ static struct i2c_driver crystal_cove_i2c_driver = {
> module_i2c_driver(crystal_cove_i2c_driver);
>
> MODULE_DESCRIPTION("I2C driver for Intel SoC PMIC");
> -MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Yang, Bin <bin.yang@intel.com>");
> MODULE_AUTHOR("Zhu, Lejun <lejun.zhu@linux.intel.com>");

--
With Best Regards,
Andy Shevchenko