Re: [PATCH 27/27] lib: packing: remove MODULE_LICENSE in non-modules

Vladimir Oltean
2023-02-24T15:22:23Z

On Fri, Feb 24, 2023 at 03:08:11PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Vladimir Oltean <olteanv@gmail.com>
> Cc: netdev@vger.kernel.org
> ---
> lib/packing.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/packing.c b/lib/packing.c
> index a96169237ae6..3f656167c17e 100644
> --- a/lib/packing.c
> +++ b/lib/packing.c
> @@ -198,5 +198,4 @@ int packing(void *pbuf, u64 *uval, int startbit, int endbit, size_t pbuflen,
> }
> EXPORT_SYMBOL(packing);
>
> -MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("Generic bitfield packing and unpacking");
> --
> 2.39.1.268.g9de2f9a303
>

Is this a bug fix? Does it need a Fixes: tag? How is it supposed to be
merged? lib/packing.c is maintained by netdev, and I believe that netdev
maintainers would prefer netdev patches to be submitted separately.

Note that I was copied only on this patch, I haven't read the cover
letter if that exists.