Re: [PATCH 04/27] mfd: intel_soc_pmic_crc: remove MODULE_LICENSE in non-modules

Nick Alcock
2023-03-06T17:06:00Z

On 3 Mar 2023, Lee Jones spake thusly:

> On Fri, 24 Feb 2023, Andy Shevchenko wrote:
>
>> On Fri, Feb 24, 2023 at 03:07:48PM +0000, Nick Alcock wrote:
>> > Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> > are used to identify modules. As a consequence, uses of the macro
>> > in non-modules will cause modprobe to misidentify their containing
>> > object file as a module when it is not (false positives), and modprobe
>> > might succeed rather than failing with a suitable error message.
>> >
>> > So remove it in the files in this commit, none of which can be built as
>> > modules.
>> >
>> > Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>>
>> > Cc: Luis Chamberlain <mcgrof@kernel.org>
>> > Cc: linux-modules@vger.kernel.org
>> > Cc: linux-kernel@vger.kernel.org
>> > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
>> > Cc: Andy Shevchenko <andy@kernel.org>
>> > Cc: Lee Jones <lee@kernel.org>
>>
>> Please, use --cc parameter instead of polluting commit message.
>
> I personally use this a lot. It's better for scripting.

Yeah.

If this is generally annoying I guess I can rejig things to use --cc-cmd
instead, somehow, but it was very convenient because it meant the
machinery which split up the commits could also compute the Cc list at
the same time without having to record it separately, but I assumed it
was routinely done from the number of Cc: trailers already in the kernel
tree...