Re: [PATCH 21/27] mfd: bcm2835-pm: remove MODULE_LICENSE in non-modules

Florian Fainelli
2023-02-24T18:38:46Z

On 2/24/23 07:08, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian