From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Maíra Canal" <mcanal@igalia.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Oded Gabbay" <ogabbay@kernel.org>
Cc: "Melissa Wen" <mwen@igalia.com>,
"André Almeida" <andrealmeid@igalia.com>,
"Emma Anholt" <emma@anholt.net>,
"Rodrigo Siqueira" <rodrigosiqueiramelo@gmail.com>,
"Wambui Karuga" <wambui@karuga.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Maíra Canal" <mcanal@igalia.com>,
"Wambui Karuga" <wambui.karugax@gmail.com>,
"Maxime Ripard" <maxime@cerno.tech>
Subject: Re: [PATCH v4 1/7] drm/debugfs: create device-centered debugfs functions
Date: Thu, 05 Jan 2023 14:44:14 +0200 [thread overview]
Message-ID: <87bkndw3q9.fsf@intel.com> (raw)
In-Reply-To: <20221219120621.15086-2-mcanal@igalia.com>
On Mon, 19 Dec 2022, Maíra Canal <mcanal@igalia.com> wrote:
> @@ -230,6 +247,12 @@ int drm_debugfs_init(struct drm_minor *minor, int minor_id,
> if (dev->driver->debugfs_init)
> dev->driver->debugfs_init(minor);
>
> + list_for_each_entry_safe(entry, tmp, &dev->debugfs_list, list) {
> + debugfs_create_file(entry->file.name, S_IFREG | S_IRUGO,
I know this was merged already, but S_IFREG is redundant, and the octal
values are preferred over S_IRUGO. See checkpatch SYMBOLIC_PERMS.
This would be just 0444.
BR,
Jani.
> + minor->debugfs_root, entry, &drm_debugfs_entry_fops);
> + list_del(&entry->list);
> + }
> +
> return 0;
> }
>
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-01-05 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 12:06 [PATCH v4 0/7] Introduce debugfs device-centered functions Maíra Canal
2022-12-19 12:06 ` [PATCH v4 1/7] drm/debugfs: create device-centered debugfs functions Maíra Canal
2023-01-05 12:44 ` Jani Nikula [this message]
2022-12-19 12:06 ` [PATCH v4 2/7] drm: use new debugfs device-centered functions on DRM core files Maíra Canal
2022-12-19 12:06 ` [PATCH v4 3/7] drm/debugfs: create debugfs late register functions Maíra Canal
2022-12-19 12:06 ` [PATCH v4 4/7] drm/vc4: use new debugfs device-centered functions Maíra Canal
2022-12-19 12:06 ` [PATCH v4 5/7] drm/v3d: " Maíra Canal
2022-12-19 12:06 ` [PATCH v4 6/7] drm/vkms: " Maíra Canal
2022-12-19 12:06 ` [PATCH v4 7/7] drm/todo: update the debugfs clean up task Maíra Canal
2022-12-19 12:49 ` [PATCH v4 0/7] Introduce debugfs device-centered functions Melissa Wen
2022-12-22 17:20 ` Daniel Vetter
2022-12-23 18:12 ` Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkndw3q9.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=ogabbay@kernel.org \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=tzimmermann@suse.de \
--cc=wambui.karugax@gmail.com \
--cc=wambui@karuga.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox