From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A01C4332F for ; Sat, 17 Dec 2022 00:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbiLQAmX (ORCPT ); Fri, 16 Dec 2022 19:42:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbiLQAmV (ORCPT ); Fri, 16 Dec 2022 19:42:21 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51D464081E for ; Fri, 16 Dec 2022 16:42:18 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id c66so5855669edf.5 for ; Fri, 16 Dec 2022 16:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rammhold-de.20210112.gappssmtp.com; s=20210112; h=message-id:date:references:in-reply-to:subject:mime-version:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=1QFKv2TWTiAAUJtUNn93KfAKVJcdR7iRnXXIRoZLyMw=; b=OTXV3ptGWNYqx2UGC2rImTpDTUqU+wDZrKWBdy/UNAoeJvPRPrVSz1tG1jGOl8Ce3e s6M+0zp3iE/xPvJ46gLuHDMM+X+dYn3oSIIkuoF8AqAxuwdnMf3jhdxb358LL+YJDcfS dZ7iY559N/VzN10NYUT2zpg7KukATI1WYLCO3n8YoWy1L2Vv1QLCrv12PzmH3hpdw7+S rHWJyzzNPFxdyh5dz4Jy/tuCgfdBOqEUZVKTu3jNQXrzZT20P3EidtaaPA+3wqG2iGvD h5s1tkyGIxQOWmtZwzxznuihpx9A3d7YWy8DoYbCcGpmaMmXppEFilwGAndn5ZPfW9CD gezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:references:in-reply-to:subject:mime-version:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1QFKv2TWTiAAUJtUNn93KfAKVJcdR7iRnXXIRoZLyMw=; b=sGicleL4pslN55j3Q82PM1GmzJV1/sOdMyUy/8Kz1ORQ09LouPn3wgHpf06f+hg2sT GbKmKkc/ycGW62HEucZXSHXBy6rOkH4DuY7YlQerpNFB8mpai06MvbkV57HZkHAq6LqJ vsPwdF0uZnh/W0eiVQaW8vCuvBO2n9qYUjE83gk54nQCnQ7v5MsoFXlHZN4HPFSxsI3i Qd+u7JEqKI4QhOX3YxegwPVTR2F4NZn43fKfFwGcQGFV7PjzGEDBBDHFx8oxMPvi2Dgd npQ94h+bYRpnbzRf6OSKXMq8vM4GDg3rAf16wTyk9A4LfNQFbJsXOmS4pvLOk3JTXvoJ XFWg== X-Gm-Message-State: AFqh2kpV2QUr+wcPeZ6vw07kxhUZvpB8XY2AV6vD78Jjd8MzshuFxd+M o5YePUAt1dbLDU58ldk0428D4a9MDdRJo4+aB84= X-Google-Smtp-Source: AMrXdXuEXjxQv82egRwfXB6YAxYwW32Z33izAMO7cRGkThTOjWfh0A7Qji8VV9ypvbxJ6Vi/3fflkA== X-Received: by 2002:a50:ed81:0:b0:477:ff25:867a with SMTP id h1-20020a50ed81000000b00477ff25867amr97915edr.12.1671237736873; Fri, 16 Dec 2022 16:42:16 -0800 (PST) Received: from localhost ([2a00:e67:3f2:a:8c01:9c4e:459b:314f]) by smtp.gmail.com with ESMTPSA id j9-20020a1709066dc900b007ad84cf1346sm1379556ejt.110.2022.12.16.16.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 16:42:15 -0800 (PST) From: Andreas Rammhold To: Rob Herring Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, Frank Rowand , linux-kernel@vger.kernel.org, John Crispin , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Frank Rowand MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [PATCH v4] of/fdt: Rework early_init_dt_scan_memory() to call directly In-Reply-To: <20211215150102.1303588-1-robh@kernel.org> References: <20211215150102.1303588-1-robh@kernel.org> Date: Sat, 17 Dec 2022 01:42:14 +0100 Message-ID: <87bko2x3mh.fsf@rammhold.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I've just debugged an issue that I traced down to this commit. My mt7621 based board relies on the soc_info.mem_detect function for memblock init which is never being called again with this patch being applied. The code in the original patch as well was on 6.0 doesn't allow any of the other (fallback?) memory initialization code to run as early_init_dt_scan_memory() always returns 0. Was this an oversight in the implementation or are some follow-up patches missing? Perhaps the code just has to return a different value when it has found some blocks of memory that should be used? Andi