Re: [PATCH][next] wifi: rtl8xxxu: Fix reads of uninitialized variables hw_ctrl_s1, sw_ctrl_s1

Kalle Valo
2022-10-21T10:48:41Z

Kalle Valo <kvalo@kernel.org> writes:

> Colin Ian King <colin.i.king@gmail.com> writes:
>
>> Variables hw_ctrl_s1 and sw_ctrl_s1 are not being initialized and
>> potentially can contain any garbage value. Currently there is an if
>> statement that sets one or the other of these variables, followed
>> by an if statement that checks if any of these variables have been
>> set to a non-zero value. In the case where they may contain
>> uninitialized non-zero values, the latter if statement may be
>> taken as true when it was not expected to.
>>
>> Fix this by ensuring hw_ctrl_s1 and sw_ctrl_s1 are initialized.
>>
>> Cleans up clang warning:
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:7: warning:
>> variable 'hw_ctrl_s1' is used uninitialized whenever 'if' condition is
>> false [-Wsometimes-uninitialized]
>> if (hw_ctrl) {
>> ^~~~~~~
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:440:7: note: uninitialized
>> use occurs here
>> if (hw_ctrl_s1 || sw_ctrl_s1) {
>> ^~~~~~~~~~
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:3: note: remove the 'if'
>> if its condition is always true
>> if (hw_ctrl) {
>> ^~~~~~~~~~~~~
>>
>> Fixes: c888183b21f3 ("wifi: rtl8xxxu: Support new chip RTL8188FU")
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> I'll queue this to v6.1.

Actually commit c888183b21f3 is in wireless-next so this patch should go
to wireless-next, for v6.2.

--