From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B6AC32771 for ; Sat, 24 Sep 2022 11:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233685AbiIXL5L (ORCPT ); Sat, 24 Sep 2022 07:57:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbiIXL5I (ORCPT ); Sat, 24 Sep 2022 07:57:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E72579AFB0 for ; Sat, 24 Sep 2022 04:57:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A9E9AB81002 for ; Sat, 24 Sep 2022 11:57:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FEB6C433D6; Sat, 24 Sep 2022 11:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664020625; bh=1B6Wz2m0/DTj9A7MHnRRSB443r6zG9ryMf8tGpPFfm0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DKSB/I3I/F02gC+JhBAk0Pa8X6hSpNEWz0UGTUaRTJZk0/XAi6h4T0VhEVfQSW6Sh 1Dv3oFMJhTVOWMv1yCpKYdnSDQ/IbnHQA9UeCPPeKztARIQkckpDGFGykxmuC++6mX VTdwBYU0Iv4U3tz3k4Q1OUBKS5uyTKvLcgcBGSo7cixv6kr1s6Qyu3Ba+uBiRkhlZh FFO4aR8OsNv/Owgb+xM1LGCQND9YuB/WIQd8oLbSZqdUJGHSYVBJcPBv36CZLzd7/a 9YUdw0t3RZ0lJst7UUxohVTSP5A0Cvarr+r0uSbCORdlkYenbBvioBsgbQ9V5weLah zUtZiy1kumgoA== Received: from 82-132-230-33.dab.02.net ([82.132.230.33] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oc3mI-00CKw6-SQ; Sat, 24 Sep 2022 12:57:03 +0100 Date: Sat, 24 Sep 2022 12:56:59 +0100 Message-ID: <87bkr5hto4.wl-maz@kernel.org> From: Marc Zyngier To: Gavin Shan Cc: kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, will@kernel.org, eric.auger@redhat.com, yuzhe@nfschina.com, oliver.upton@linux.dev, shan.gavin@gmail.com, James Morse , Suzuki K Poulose , Alexandru Elisei Subject: Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection() In-Reply-To: <20220923065447.323445-1-gshan@redhat.com> References: <20220923065447.323445-1-gshan@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 82.132.230.33 X-SA-Exim-Rcpt-To: gshan@redhat.com, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, will@kernel.org, eric.auger@redhat.com, yuzhe@nfschina.com, oliver.upton@linux.dev, shan.gavin@gmail.com, james.morse@arm.com, suzuki.poulose@arm.com, Alexandru.Elisei@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gavin, Side note: please make sure you always Cc all the KVM/arm64 reviewers when sending patches (now added). On Fri, 23 Sep 2022 07:54:47 +0100, Gavin Shan wrote: > > The ITS collection is guranteed to be !NULL when update_affinity_collection() > is called. So we needn't check ITE's collection with NULL because the > check has been included to the later one. It took me a while to understand what you meant by this: the 'coll' parameter to update_affinity_collection() is never NULL, so comparing it with 'ite->collection' is enough to cover both the NULL case and the "another collection" case. If you agree with this, I can directly fix the commit message when applying the patch. Thanks, M. -- Without deviation from the norm, progress is not possible.