Re: [PATCH v2 0/5] Address some issues with sphinx detection

Mauro Carvalho Chehab
2022-07-07T20:25:48Z

Em Thu, 07 Jul 2022 12:45:14 -0600
Jonathan Corbet <corbet@lwn.net> escreveu:

> Akira Yokosawa <akiyks@gmail.com> writes:
>
> > TL;DR, my suggestion of options and defaults to sphinx-pre-install:
> >
> > --no-pdf (default): for htmldocs only
> > --no-virtualenv (default): distro Sphinx package
> > (mention --virtualenv if distro Sphinx package is too young)
> > --virtualenv: Sphinx by venv/virtualenv
> > --pdf: for pdfdocs
> > --no-cjk (default): don't bother with CJK pdfdocs
> > --cjk: for CJK pdfdocs
> > (print warning if user's distro doesn't support CJK)
> > Thoughts?
>
> I think this makes sense. As far as I can tell, PDF builds are a
> relative rarity these days, and most people would rather not have to
> deal with virtualenv if they can avoid it. We should definitely
> emphasize native installs whenever that can work.
>
> I'm planning to go ahead and apply Mauro's sphinx-pre-install patches
> since they make things better, but then we should look at these tweaks.

IMO it makes sense to apply them, as they address some existing issues
on it.

We can improve the script later on with Akira's comments and after having
some discussions about what would be the default behavior that would fit
better.

Regards,
Mauro