From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA2BC433F5 for ; Wed, 4 May 2022 11:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348492AbiEDLG7 (ORCPT ); Wed, 4 May 2022 07:06:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348461AbiEDLG4 (ORCPT ); Wed, 4 May 2022 07:06:56 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A72E17E24; Wed, 4 May 2022 04:03:17 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4KtYpR36kMz4x7V; Wed, 4 May 2022 21:03:10 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1651662194; bh=LCpTjFnDEwsYkNeVhJ/7ZfUx41S6pzSAGCwTzE+zXeE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oSdsWchJ7c6LaWBbTkrN4HY/gAMdpQJZcaKFI7EDhV0JeJSI6Ilrh5JXSrxrO+uBi fz7astncBphLXFWCOHhi/UuBJgXcyFzZqYPiGHlIi6X45BigzITOjmK1rMnK6xaTol wK+Fl001hFDLFxA3kebNvk3NpO9blGLOH5shsbSldk7k/YPS8CY+2HU/0urlMYnQPi 3f3A20Ra29iiAIuItwlZHJn/lAKzlgp6ft6XtuAwcXeHVWlSH3tlipFUOHXN4lOi74 kINmxaDpdRmWpd8ejwQmQIqRTqnHtMk+0OO2DYANcnQC+pIYh1SpDofrsXa2SehLI+ bhi5wSivAPsvA== From: Michael Ellerman To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Greg KH , linux-serial Cc: Jiri Slaby , linux-api@vger.kernel.org, Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Arnd Bergmann , linux-arch@vger.kernel.org, LKML Subject: Re: [PATCH 1/1] termbits: Convert octal defines to hex In-Reply-To: <2c8c96f-a12f-aadc-18ac-34c1d371929c@linux.intel.com> References: <2c8c96f-a12f-aadc-18ac-34c1d371929c@linux.intel.com> Date: Wed, 04 May 2022 21:03:09 +1000 Message-ID: <87bkwdv9ua.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ilpo J=C3=A4rvinen writes: > Many archs have termbits.h as octal numbers. It makes hard for humans > to parse the magnitude of large numbers correctly and to compare with > hex ones of the same define. > > Convert octal values to hex. > > First step is an automated conversion with: > > for i in $(git ls-files | grep 'termbits\.h'); do > awk --non-decimal-data '/^#define\s+[A-Z][A-Z0-9]*\s+0[0-9]/ { > l=3Dint(((length($3) - 1) * 3 + 3) / 4); > repl =3D sprintf("0x%0" l "x", $3); > print gensub(/[^[:blank:]]+/, repl, 3); > next} {print}' $i > $i~; > mv $i~ $i; > done > > On top of that, some manual processing on alignment and number of zeros. > In addition, small tweaks to formatting of a few comments on the same=20 > lines. > > Signed-off-by: Ilpo J=C3=A4rvinen > --- > > I prefer this to go in though Greg's tty tree. > > arch/alpha/include/uapi/asm/termbits.h | 202 ++++++++++----------- > arch/mips/include/uapi/asm/termbits.h | 222 +++++++++++------------ > arch/parisc/include/uapi/asm/termbits.h | 220 +++++++++++----------- > arch/powerpc/include/uapi/asm/termbits.h | 202 ++++++++++----------- I ran some horrible awk/sed/python mess over the before and after and they seem to be numerically identical, so LGTM. Acked-by: Michael Ellerman (powerpc) cheers