Re: [PATCH printk v1 05/10] printk: call boot_delay_msec() in printk_delay()

Sergey Senozhatsky
2021-08-31T01:04:59Z

On (21/08/03 15:18), John Ogness wrote:
> boot_delay_msec() is always called immediately before printk_delay()
> so just call it from within printk_delay().

[..]

Interesting. Apparently boot_delay_msec() does not do anything
if suppress_message_printing(level). I wonder if we want a similar
thing for printk_delay() as well. Otherwise we have some imbalance in
behaviour.

IOW,

> @@ -1222,10 +1222,8 @@ static void boot_delay_msec(int level)
> unsigned long long k;
> unsigned long timeout;
>
>- if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
>- || suppress_message_printing(level)) {
>+ if (boot_delay == 0 || system_state >= SYSTEM_RUNNING)
> return;
>- }
>
> k = (unsigned long long)loops_per_msec * boot_delay;

[..]

> +static inline void printk_delay(int level)
> {

+ if (suppress_message_printing(level))
+ return;

> + boot_delay_msec(level);
> +
> if (unlikely(printk_delay_msec)) {
> int m = printk_delay_msec;
>