From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, BUG6152_INVALID_DATE_TZ_ABSURD,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INVALID_DATE_TZ_ABSURD,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 543A6C433DB for ; Tue, 2 Feb 2021 08:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02C5464E2A for ; Tue, 2 Feb 2021 08:45:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232547AbhBBIpj (ORCPT ); Tue, 2 Feb 2021 03:45:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbhBBIph (ORCPT ); Tue, 2 Feb 2021 03:45:37 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F4174C061573 for ; Tue, 2 Feb 2021 00:44:56 -0800 (PST) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1612255495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mNqc9XcHFo5uNF2W+JXo18dFCyeXoeAXi1CqG297LtY=; b=hbdcpaoU/0UqPrnl07yNS5UCnwto4xw8sL+knusJNbCXg8w/HkaYxzyKkV7mzEtHFiJwy8 vjNCEoYKloEGpba4gTCXV8+RGEiu1UN7IatGBjmgIqOejImDt1qroBizHNyfAZp/BEjbD1 kzp9lkmGteYwX6op9idgiKfTO9pnXJ43NZLS2Ix9Ca9jmwROrrqiCN61934LbAqihfYioj g9KoarOg/AZX1hYvCNfrfRNx9pYwmiQELHe5xjAaDKe7MIkFKtXu63a37JF9d9bTIDPFML XiwEgbUI9PzTRuipxtuOF7zp6UEY8uuo2L87zrOIEivl0DF3m15b5Q2neSO6tw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1612255495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mNqc9XcHFo5uNF2W+JXo18dFCyeXoeAXi1CqG297LtY=; b=QFmgSZFu1TtTN76yGhp3cTN8sIMK3IoHvFqH3ZtKnOVj043vc6gXBNnN41/YRPzE7JXe+i RZ22Zz5r3vwAPEAw== To: Masahiro Yamada , linux-kernel@vger.kernel.org, Petr Mladek , Sergey Senozhatsky , Steven Rostedt Cc: Masahiro Yamada Subject: Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c In-Reply-To: <20210202070218.856847-3-masahiroy@kernel.org> References: <20210202070218.856847-1-masahiroy@kernel.org> <20210202070218.856847-3-masahiroy@kernel.org> Date: Tue, 02 Feb 2021 09:50:54 +0106 Message-ID: <87bld22709.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-02-02, Masahiro Yamada wrote: > This macro is only used in kernel/printk/printk.c I recently posted a patch [0] that added another macro CONSOLE_LOG_MAX here. But it also is only used in printk.c. I see no reason why either should be in the header. Neither my patch nor commit d43ff430f434 ("printk: guard the amount written per line by devkmsg_read()") show any motivation for using printk.h. I am fine with moving them out. The only consequences could be out-of-tree modules breaking, but do we care about that? John Ogness [0] https://lkml.kernel.org/r/20210126211551.26536-5-john.ogness@linutronix.de