Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c

John Ogness
2021-02-02T08:45:41Z

On 2021-02-02, Masahiro Yamada <masahiroy@kernel.org> wrote:
> This macro is only used in kernel/printk/printk.c

I recently posted a patch [0] that added another macro CONSOLE_LOG_MAX
here. But it also is only used in printk.c. I see no reason why either
should be in the header. Neither my patch nor commit d43ff430f434
("printk: guard the amount written per line by devkmsg_read()") show any
motivation for using printk.h.

I am fine with moving them out. The only consequences could be
out-of-tree modules breaking, but do we care about that?

John Ogness

[0] https://lkml.kernel.org/r/20210126211551.26536-5-john.ogness@linutronix.de