public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiafei Pan <Jiafei.Pan@nxp.com>,
	peterz@infradead.org, mingo@kernel.org, rostedt@goodmis.org,
	romain.perier@gmail.com, will@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
	jiafei.pan@nxp.com, leoyang.li@nxp.com, vladimir.oltean@nxp.com,
	Jiafei Pan <Jiafei.Pan@nxp.com>
Subject: Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff
Date: Thu, 13 Aug 2020 09:33:31 +0200	[thread overview]
Message-ID: <87bljf57as.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200806040729.39186-1-Jiafei.Pan@nxp.com>

Jiafei Pan <Jiafei.Pan@nxp.com> writes:
> __raise_softirq_irqoff will update per-CPU mask of pending softirqs,

Please write __raise_softirq_irqoff() so it's clear that this is about a
function.

>  void __raise_softirq_irqoff(unsigned int nr)
>  {
> +	/* This function can only be called in irq disabled context,
> +	 * otherwise or_softirq_pending will be interrupted by hardware
> +	 * interrupt, so that there will be unexpected issue.
> +	 */
> +	WARN_ON_ONCE(!irqs_disabled());

Please use lockdep_assert_irqs_disabled() instead.

Thanks,

        tglx

      parent reply	other threads:[~2020-08-13  7:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06  4:07 [PATCH] softirq: add irq off checking for __raise_softirq_irqoff Jiafei Pan
2020-08-13  3:03 ` Jiafei Pan
2020-08-13 14:56   ` Steven Rostedt
2020-08-14  2:21     ` [EXT] " Jiafei Pan
2020-08-14  2:24       ` Steven Rostedt
2020-08-14  4:17     ` Jiafei Pan
2020-08-13  5:58 ` Peter Zijlstra
2020-08-14  3:28   ` [EXT] " Jiafei Pan
2020-08-13  7:33 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bljf57as.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Jiafei.Pan@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=romain.perier@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=vladimir.oltean@nxp.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox