Re: [PATCH][next] zd1211rw/zd_usb.h: Replace zero-length array with flexible-array member

Gustavo A. R. Silva
2020-03-10T22:34:01Z

On 3/10/20 5:28 PM, Joe Perches wrote:
> On Tue, 2020-03-10 at 17:21 -0500, Gustavo A. R. Silva wrote:
>> On 3/10/20 5:15 PM, Joe Perches wrote:
>>> As far as I can tell, it doesn't actually make a difference as
>>> all the compilers produce the same object code with either form.
>>>
>>
>> That's precisely why we can implement these changes, cleanly(the fact
>> that the compiler produces the same object code). So, the resulting
>> object code is not the point here.
>
> You are making Jes' point.
>

Please, see my other reply.

> There's nothing wrong with making changes just for consistent
> style across the kernel.
>
> This change is exactly that.
>
> I have no objection to this patch.
>
> Jes does, though Jes is not a maintainer of this file.
>
> I think "churn" arguments are overstated.
>

I agree.

Thanks
--
Gustavo