From: Kalle Valo <kvalo@codeaurora.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc2
Date: Tue, 30 Jul 2019 17:43:55 +0300 [thread overview]
Message-ID: <87blxbmvkk.fsf@codeaurora.org> (raw)
In-Reply-To: <877e80ne9n.fsf@codeaurora.org> (Kalle Valo's message of "Tue, 30 Jul 2019 11:00:04 +0300")
Kalle Valo <kvalo@codeaurora.org> writes:
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
>
>> On 7/27/19 1:08 PM, Linus Torvalds wrote:
>>
>>>
>>> Ok, I have tried re-pulling and if it passes my build tests cleanly
>>> I'll push the result out.
>>>
>>
>> Awesome. :)
>
> BTW, now when using ccache 3.2.4 (which I admit is an old release from
> 2015 but included still in Ubuntu 16.04) I see a lot of fall-through
> warnings when building the kernel. I reported this to Gustavo before but
> didn't find the time to answer back to his extra questions, sorry about
> that.
>
> I did investigate the issue at the time and IIRC it was because ccache
> strips away the comments (including the fallback comments) before
> feeding the source file to the compiler. Apparently newer ccache
> versions has a setting to avoid that but I have not tried upgrading yet.
> But anyone using old ccache should definitely upgrade.
I just installed ccache 3.4.1-1 from Ubuntu 18.04 and that seemed to fix
the problem, the big number of fallthrough warnings are now gone. No
extra configuration needed.
--
Kalle Valo
next prev parent reply other threads:[~2019-07-30 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 2:55 [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc2 Gustavo A. R. Silva
2019-07-27 17:30 ` Gustavo A. R. Silva
2019-07-27 18:08 ` Linus Torvalds
2019-07-27 19:38 ` Gustavo A. R. Silva
2019-07-30 8:00 ` Kalle Valo
2019-07-30 14:43 ` Kalle Valo [this message]
2019-07-27 18:40 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2019-07-24 19:07 Gustavo A. R. Silva
2019-07-22 19:58 Gustavo A. R. Silva
2019-07-22 21:52 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blxbmvkk.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox