From: Michael Ellerman <mpe@ellerman.id.au>
To: frowand.list@gmail.com, Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] of: remove *phandle properties from expanded device tree
Date: Thu, 15 Jun 2017 16:53:03 +1000 [thread overview]
Message-ID: <87bmpppws0.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1497073632-22402-2-git-send-email-frowand.list@gmail.com>
frowand.list@gmail.com writes:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Remove "phandle", "linux,phandle", and "ibm,phandle" properties from
> the internal device tree. The phandle will still be in the struct
> device_node phandle field.
>
> This is to resolve the issue found by Stephen Boyd [1] when he changed
> the type of struct property.value from void * to const void *. As
> a result of the type change, the overlay code had compile errors
> where the resolver updates phandle values.
>
> [1] http://lkml.iu.edu/hypermail/linux/kernel/1702.1/04160.html
>
> - Add sysfs infrastructure to report np->phandle, as if it was a property.
> - Do not create "phandle" "ibm,phandle", and "linux,phandle" properties
> in the expanded device tree.
> - Remove phandle properties in of_attach_node(), for nodes dynamically
> attached to the live tree. Add the phandle sysfs entry for these nodes.
> - When creating an overlay changeset, duplicate the node phandle in
> __of_node_dup().
> - Remove no longer needed checks to exclude "phandle" and "linux,phandle"
> properties in several locations.
> - A side effect of these changes is that the obsolete "linux,phandle" and
> "ibm,phandle" properties will no longer appear in /proc/device-tree (they
> will appear as "phandle").
> - A side effect is that the value of property "ibm,phandle" will no longer
> override the value of properties "phandle" and "linux,phandle".
Can you please Cc linuxppc-dev in future on patches which clearly are
going to impact powerpc?
cheers
next prev parent reply other threads:[~2017-06-15 6:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 5:47 [PATCH v5 0/4] of: remove *phandle properties from expanded device tree frowand.list
2017-06-10 5:47 ` [PATCH v5 1/4] " frowand.list
2017-06-15 6:53 ` Michael Ellerman [this message]
2017-06-10 5:47 ` [PATCH v5 2/4] of: make __of_attach_node() static frowand.list
2017-06-10 5:47 ` [PATCH v5 3/4] of: be consistent in form of file mode frowand.list
2017-06-10 5:47 ` [PATCH v5 4/4] of: detect invalid phandle in overlay frowand.list
2017-06-13 22:08 ` [PATCH v5 0/4] of: remove *phandle properties from expanded device tree Rob Herring
2017-06-16 0:06 ` Benjamin Herrenschmidt
2017-06-16 1:31 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmpppws0.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox