From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425373AbdD1JLo (ORCPT ); Fri, 28 Apr 2017 05:11:44 -0400 Received: from mail.leader.jabatus.fr ([109.234.163.55]:55148 "EHLO mail.leader.jabatus.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425346AbdD1JL0 (ORCPT ); Fri, 28 Apr 2017 05:11:26 -0400 X-MailPropre-MailScanner-From: dev@michaelmera.com X-MailPropre-MailScanner-SpamCheck: not spam, SpamAssassin (cached, score=0.901, required 5, autolearn=disabled, BAYES_20 1.00, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10, URIBL_BLOCKED 0.00) X-MailPropre-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details X-MailPropre-MailScanner-ID: 888B36D7D12EC.AE298 X-MailPropre-MailScanner-Information: Message sortant - Serveurs o2switch From: Michael Mera To: Greg Kroah-Hartman Cc: William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , linux-kernel@vger.kernel.org, Michael Mera Subject: Re: [PATCH v2] staging: speakup: fix wrong code indent In-Reply-To: <20170428090034.GA3436@kroah.com> References: <20170428071146.GA27730@kroah.com> <20170428084607.21405-1-dev@michaelmera.com> <20170428090034.GA3436@kroah.com> Date: Fri, 28 Apr 2017 18:11:04 +0900 Message-ID: <87bmrgj3rr.fsf@michaelmera.com> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - citrus.o2switch.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - michaelmera.com X-Get-Message-Sender-Via: citrus.o2switch.net: authenticated_id: dev@michaelmera.com X-Authenticated-Sender: citrus.o2switch.net: dev@michaelmera.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote: >> Remove unnecessary multiline comment, fixes checkpatch messages: >> ERROR: code indent should use tabs where possible >> WARNING: Block comments should align the * on each line >> >> Signed-off-by: Michael Mera >> --- >> drivers/staging/speakup/speakup_decpc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > What changed from v1? That needs to go below the --- line. Oh. Sorry. I fixed the spelling of the patch message, since I though that was the problem you detected but... > > And I think my previous email still is relevant here... ... apparently not. I double checked the patch with 'checkpatch --strict' and it does not detect any problem this time. Sorry if I missed something obvious, I am quite new to this, but could you give me some additional hint about the problem.