From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970299AbdAEJXg (ORCPT ); Thu, 5 Jan 2017 04:23:36 -0500 Received: from mga02.intel.com ([134.134.136.20]:55841 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967215AbdAEJXO (ORCPT ); Thu, 5 Jan 2017 04:23:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,320,1477983600"; d="asc'?scan'208";a="919172910" From: Felipe Balbi To: Manish Narani , "robh+dt\@kernel.org" , "mark.rutland\@arm.com" , "catalin.marinas\@arm.com" , "will.deacon\@arm.com" , "michal.simek\@xilinx.com" , Soren Brinkmann , "gregkh\@linuxfoundation.org" , "mathias.nyman\@intel.com" , "agraf\@suse.de" , Bharat Kumar Gogada , Punnaiah Choudary Kalluri , "dhdang\@apm.com" , "marc.zyngier\@arm.com" , "devicetree\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" , "linux-kernel\@vger.kernel.org" , "linux-usb\@vger.kernel.org" Cc: Anirudha Sarangi , Anurag Kumar Vulisha Subject: RE: [RFC PATCH] usb: dwc3: add support for OTG driver compilation In-Reply-To: References: <1483536181-22356-1-git-send-email-mnarani@xilinx.com> <1483536181-22356-2-git-send-email-mnarani@xilinx.com> <87r34jvtn5.fsf@linux.intel.com> Date: Thu, 05 Jan 2017 11:20:30 +0200 Message-ID: <87bmvlx3q9.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Manish Narani writes: > Hi Felipe, > > >> From: Felipe Balbi [mailto:balbi@kernel.org] >> Sent: Wednesday, January 04, 2017 7:01 PM >> Hi, >> >> Manish Narani writes: >> > This patch adds support for OTG driver compilation and object file >> > creation >> > >> > Signed-off-by: Manish Narani >> > --- >> > drivers/usb/dwc3/Makefile | 4 ++++ >> > 1 file changed, 4 insertions(+) >> > >> > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile >> > index ffca340..2d269ad 100644 >> > --- a/drivers/usb/dwc3/Makefile >> > +++ b/drivers/usb/dwc3/Makefile >> > @@ -17,6 +17,10 @@ ifneq ($(filter y,$(CONFIG_USB_DWC3_GADGET) >> $(CONFIG_USB_DWC3_DUAL_ROLE)),) >> > dwc3-y +=3D gadget.o ep0.o >> > endif >> > >> > +ifneq ($(CONFIG_USB_DWC3_DUAL_ROLE),) >> > + dwc3-y +=3D otg.o >> > +endif >> >> you just broke compilation > > Should I add new USB_DWC3_OTG macro in Kconfig? No, no. Reset your tree to this commit and try to compile it. Problem should be clear. > This email and any attachments are intended for the sole use of the > named recipient(s) and contain(s) confidential information that may be > proprietary, privileged or copyrighted under applicable law. If you > are not the intended recipient, do not read, copy, or forward this > email message or any attachments. Delete this email message and any > attachments immediately. you should make sure these notes aren't sent to public mailing lists. I'll delete this email of yours and stop reading them until this is sorted out. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlhuD94ACgkQzL64meEa mQa5fRAAnIh8an1sX7UGFAn4Ql8Y3T8JBxU1RDJavS/O4UE33BN8Oog43cvBAz3z tqYjVH0CW6aHgd9K0Ic8qSraTL0drlNny3LV+kqmhzsTHBohxHt22wEZVJEpIAbH 1Dr/cWxP3lXTQYjR1E7zbn2c2kStr5vUI8kC5yPIYEWUfsrxsi9nb5mPJ7xdQ7S2 dgJDKtGO0xM4NZvU065ohpjnP0WD/otSzFOjL+v6gbF4uS0ptVwxtySkg9jveSeb 3lqy4UQx3KQ2gPZU5n1FG1zPbadjBHZNLPG2btEE0dVI3vAbm0hYgciys4HZNuxV NuRNxTebfMTyF/wQoHeb/VrwkdNnXVcTGmN+M4IKA4PcJkJDE7F0MyvKFvisSd6L zzQrhGT80qcRz5qt7JNWaklMMPcQbTrSgIgbfBYE7CwQx1HV/xDwHxbQz2aMhdBq ssyodeCwolLwDKsts45qPtXea0IBj4bQZAY+l4HJcHqY5K2hs38ESjGmNe5G7F2Z 6fs5azIH9pY4lg6tcIptQ28VVkl6kN13e5uZHLXkP2ROzkqNQSn5SulhvIsqHWaL 7bvXekJiNbu3G7Ah78Xd9ftu3on9RQKoiFXnYYIEfdAgYBR94giAHTe67mTuZ/2y SFHfD5ux/eRZsSyLNJbPaGG/DibW0u4XV6ibaSnh+6uECoeR6Og= =h9IE -----END PGP SIGNATURE----- --=-=-=--