From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967163AbcHBN7D (ORCPT ); Tue, 2 Aug 2016 09:59:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:29786 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966732AbcHBN60 (ORCPT ); Tue, 2 Aug 2016 09:58:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="asc'?scan'208";a="149361822" From: Felipe Balbi To: Baole Ni , gregkh@linuxfoundation.org, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter.chen@freescale.com, mina86@mina86.com, deepa.kernel@gmail.com, mathias.nyman@linux.intel.com, stern@rowland.harvard.edu, chuansheng.liu@intel.com, baolex.ni@intel.com, oneukum@suse.com Subject: Re: [PATCH 0984/1285] Replace numeric parameter like 0444 with macro In-Reply-To: <20160802120521.15675-1-baolex.ni@intel.com> References: <20160802120521.15675-1-baolex.ni@intel.com> User-Agent: Notmuch/0.22+58~g3a45d29 (https://notmuchmail.org) Emacs/25.0.95.2 (x86_64-pc-linux-gnu) Date: Tue, 02 Aug 2016 16:54:31 +0300 Message-ID: <87bn1bqns8.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permiss= ion. > As we know, these numeric value for access permission have had the corres= ponding macro, > and that using macro can improve the robustness and readability of the co= de, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > drivers/usb/misc/usbtest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > index 6b978f0..5e81dc3 100644 > --- a/drivers/usb/misc/usbtest.c > +++ b/drivers/usb/misc/usbtest.c > @@ -15,7 +15,7 @@ > /*----------------------------------------------------------------------= ---*/ >=20=20 > static int override_alt =3D -1; > -module_param_named(alt, override_alt, int, 0644); > +module_param_named(alt, override_alt, int, S_IRUSR | S_IWUSR | S_IRGRP |= S_IROTH); line too long. You need to run this series through scripts/checkpatch.pl =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXoKYXAAoJEIaOsuA1yqRErvgP/jMY2TiE8K8Qk60Xf3GvqllS 5vOvsxiM2WWnsbVP2yLxkKX0lUacFrV/iVh0IRoJia59RQJyM3dl+0SU3INuqQ7w SLPVzGUoTeewBZ2ZR5bw1r9crjM6TrkFdxIwDN2ILFJYpNl3hRbwQ5VzXNXsp7Y+ nnZ6A4HiXzJZSntBisANhovh2zZtksgi/nbZx8V4PglhdoG3yQ4eOnyvwQiw7Mm0 BJuMRDHlgBGS1j8tCgYeZsAFPaOMXyO3bM2f2Dstp4uTaiK1YBYl0ITo7+C+A+ij 2gBIr3JC56XVssVUJ8h46EzbccF3at1JB94Q1tp92gN8nLODLqzC8MKQ4+aDMqom 37SbloNkLIDc5gE8tuEGdnn/AtHW3mdCjNUjIQ7OGMCGkDUxlhPU6wK0sqbJZAev 2g2aWMVOUh6zR97jpH4juXzWzTGXKkTTP3cw08bB77Y+ENj4Ap27zEYwn3J1Vm/H 81Zy7anT3TOQo94nNUbJ/1nmDpwX6Q850oYT4Dgckx3t4TkJ2GWqpXrglUAohy3K 1OLrw3nlGOdkzTJjhi/dHHFeXG8o2Im1xde3dac6VndrsBEGUyYS6bFStmERIfav A7Yagl20QRTIP9YwMxJOAgNRxhNUgb1aWWUiWiRrNhuknJjedOlFFkSj8yVFKPG9 UZKr2bp93uJ8OiAiPQor =GxKh -----END PGP SIGNATURE----- --=-=-=--