Re: [PATCH] usb: dwc3: free dwc->regset on dwc3_debugfs_exit

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

changbin.du@intel.com writes:
> From: "Du, Changbin" <changbin.du@intel.com>
>
> dwc->regset is allocated on dwc3_debugfs_init, and should
> be released on dwc3_debugfs_exit.
>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
> ---
> This patch is seperated from patch set:
>  [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs
> Because it is not related to other 2 patches.
>
> ---
>  drivers/usb/dwc3/debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index 9ac37fe..9eeb444 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -687,4 +687,7 @@ void dwc3_debugfs_exit(struct dwc3 *dwc)
>  {
>  	debugfs_remove_recursive(dwc->root);
>  	dwc->root = NULL;
> +
> +	kfree(dwc->regset);

we also need a kfree() on dwc3_debugfs_init().

> +	dwc->regset = NULL;

setting regset to NULL is unnecessary. We only call dwc3_debugfs_exit()
when removing the driver.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]