From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756018AbcBVWjD (ORCPT ); Mon, 22 Feb 2016 17:39:03 -0500 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:43276 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752159AbcBVWjB (ORCPT ); Mon, 22 Feb 2016 17:39:01 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 22 Feb 2016 23:39:00 +0100 X-ME-IP: 109.220.219.11 From: Robert Jarzmik To: Haojian Zhuang , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Daniel Mack , Eric Miao , linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] ARM: mmp: mark usb_dma_mask as __maybe_unused References: <1454076396-3563101-1-git-send-email-arnd@arndb.de> <1454076396-3563101-10-git-send-email-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 22 Feb 2016 23:38:56 +0100 In-Reply-To: <1454076396-3563101-10-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 29 Jan 2016 15:06:33 +0100") Message-ID: <87bn78wetb.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > This variable may be used by some devices that each have their > on Kconfig symbol, or by none of them, and that causes a build > warning: > > arch/arm/mach-mmp/devices.c:241:12: error: 'usb_dma_mask' defined but not used [-Werror=unused-variable] > > Marking it __maybe_unused avoids the warning. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-mmp/devices.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Haojian, I still didn't get an ack on this one, do you want to carry it through your tree, or let Arnd carry it or let me carry it ? Cheers. -- Robert [1] The patch > diff --git a/arch/arm/mach-mmp/devices.c b/arch/arm/mach-mmp/devices.c > index 3330ac7cfbef..671c7a09ab3d 100644 > --- a/arch/arm/mach-mmp/devices.c > +++ b/arch/arm/mach-mmp/devices.c > @@ -238,7 +238,7 @@ void pxa_usb_phy_deinit(void __iomem *phy_reg) > #endif > > #if IS_ENABLED(CONFIG_USB_SUPPORT) > -static u64 usb_dma_mask = ~(u32)0; > +static u64 __maybe_unused usb_dma_mask = ~(u32)0; > > #if IS_ENABLED(CONFIG_USB_MV_UDC) > struct resource pxa168_u2o_resources[] = { -- Robert