From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756568AbcBESuJ (ORCPT ); Fri, 5 Feb 2016 13:50:09 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:50065 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754397AbcBESuH (ORCPT ); Fri, 5 Feb 2016 13:50:07 -0500 X-Auth-Info: X1bDn2W21MMfx+n5x9YqCd66SFy4THVXH8Wej/5v8xzPBJODzXGNWJxw2Fxg5XKt From: Andreas Schwab To: linuxppc-dev@ozlabs.org Subject: [PATCH] powerpc: fix dedotify for binutils >= 2.26 CC: linux-kernel@vger.kernel.org X-Yow: I OWN six pink HIPPOS!! Date: Fri, 05 Feb 2016 19:50:03 +0100 Message-ID: <87bn7vm1pg.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since binutils 2.26 BFD is doing suffix merging on STRTAB sections. But dedotify modifies the symbol names in place, which can also modify unrelated symbols with a name that matches a suffix of a dotted name. To remove the leading dot of a symbol name we can just increment the pointer into the STRTAB section instead. Signed-off-by: Andreas Schwab --- arch/powerpc/kernel/module_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module_64.c index ac64ffd..08b7a40 100644 --- a/arch/powerpc/kernel/module_64.c +++ b/arch/powerpc/kernel/module_64.c @@ -340,7 +340,7 @@ static void dedotify(Elf64_Sym *syms, unsigned int numsyms, char *strtab) if (name[0] == '.') { if (strcmp(name+1, "TOC.") == 0) syms[i].st_shndx = SHN_ABS; - memmove(name, name+1, strlen(name)); + syms[i].st_name++; } } } -- 2.7.0 -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."