From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Xunlei Pang <xlpang@redhat.com>
Subject: Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero
Date: Mon, 07 Dec 2015 12:26:23 +1030 [thread overview]
Message-ID: <87bna3rph4.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20151206172936.GA29582@gmail.com>
Ingo Molnar <mingo@kernel.org> writes:
> * Rusty Russell <rusty@rustcorp.com.au> wrote:
>> I don't think there are great answers here. But adding more subtle zeroing
>> semantics feels wrong, even if it will mostly Just Work.
>
> It's not subtle if the naming clearly reflects it (hence my suggestion to rename
> the API) - and the status quo for on-stack allocations is zeroing anyway, so it's
> not a big jump...
True, but we already have zalloc_cpumask_var() though if we want that?
It probably makes sense to just switch everyone to that and get rid of
the non-z one?
Cheers,
Rusty.
next prev parent reply other threads:[~2015-12-07 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 22:24 [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Steven Rostedt
2015-12-04 1:35 ` Rusty Russell
2015-12-04 2:37 ` Steven Rostedt
2015-12-04 7:34 ` Ingo Molnar
2015-12-04 20:30 ` Rusty Russell
2015-12-06 17:29 ` Ingo Molnar
2015-12-07 1:56 ` Rusty Russell [this message]
2015-12-07 8:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bna3rph4.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).