From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932752AbbI3TfT (ORCPT ); Wed, 30 Sep 2015 15:35:19 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:45011 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753675AbbI3TfM (ORCPT ); Wed, 30 Sep 2015 15:35:12 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 30 Sep 2015 21:35:10 +0200 X-ME-IP: 86.199.64.143 From: Robert Jarzmik To: Thierry Reding , Nicolas Ferre Cc: Jingoo Han , Lee Jones , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "backlight: pwm: Handle EPROBE_DEFER while requesting the PWM" References: <1443295482-18687-1-git-send-email-robert.jarzmik@free.fr> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 30 Sep 2015 21:29:59 +0200 In-Reply-To: <1443295482-18687-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Sat, 26 Sep 2015 21:24:42 +0200") Message-ID: <87bncjemdk.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Robert Jarzmik writes: > This reverts commit 68feaca0b13e453aa14ee064c1736202b48b342f. > This commit breaks legacy platforms, for which : > (a) no pwm table is added (legacy platforms) > (b) in this case, in pwm_get(), pmw_lookup_list is empty, and therefore > chosen == NULL, and therefore pwm_get() returns NULL, and pwm_get() > returns -EPROBE_DEFER > (c) as a consequence, this code is unreachable in pwm_bl.c : > if (IS_ERR(pb->pwm)) { > ret = PTR_ERR(pb->pwm); > dev_info(&pdev->dev, "%s:%d(): %d\n", __func__, __LINE__, ret); > if (ret == -EPROBE_DEFER) > goto err_alloc; > > dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n"); > pb->legacy = true; > pb->pwm = pwm_request(data->pwm_id, "pwm-backlight"); > > As this code is unreachable, all legacy platforms relying on pwm_id are > broken, amongst which pxa have been tested as broken. > > Signed-off-by: Robert Jarzmik Thierry, would you have a look please ? As I said before, all legacy platform relying on pwm_id are broken. I'd like to be sure this lands in the next -rc series. Cheers. -- Robert