Re: [PATCH 1/2] ktest: add 2nd parameter of run_command() to set the redirect target file

[Satoru Takeuchi <satoru.takeuchi@gmail.com>]

At Fri, 7 Mar 2014 19:43:28 -0500,
Steven Rostedt wrote:
> 
> On Sat, 08 Mar 2014 09:12:31 +0900
> Satoru Takeuchi <satoru.takeuchi@gmail.com> wrote:
> 
> > Hi Steven,
> > 
> > At Sun, 02 Mar 2014 21:20:31 +0900,
> > Satoru Takeuchi wrote:
> > > 
> > > From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
> > > 
> > > If we'd like to set the redirect target file of run_command(),
> > > we should define $redirect before calling this function and should undef it
> > > after calling this function. Since it's user-unfriendly, add 2nd parameter of
> > > run_command() for this purpose.
> > > 
> > > Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
> > > Cc: Steven Rostedt <rostedt@goodmis.org>
> > 
> > Could you tell whether this patch will be applied? Although you told me that you
> > won't apply the following patch, I didn't hear about this patch.
> 
> Ah, I was thinking this one was needed for the next patch, so I didn't
> apply it.

The two patches don't depend on earch other.

> 
> > 
> > > [PATCH 2/2] ktest: run make mrproper not only for OUTPUT_DIR but also for BUILD_DIR to avoid build failure
> > 
> > I make this question since I'll send next patch set this weekend and want to
> > know whether I can make patch on the top of this patch.
> 
> You can add this one again. I haven't really reviewed it, but if other
> patches depend on it, include it as well. Include it anyway if you want
> me to review it.

OK, I'll resend patch 1/2 at the next post of my patchset.

Thanks,
Satoru

> 
> Thanks,
> 
> -- Steve
> 
>