From: Nix <nix@esperi.org.uk>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 3.4.x regression: rtl8169: frequent resets
Date: Fri, 29 Jun 2012 00:10:49 +0100 [thread overview]
Message-ID: <87bok3oww6.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <20120628222325.GA1579@electric-eye.fr.zoreil.com> (Francois Romieu's message of "Fri, 29 Jun 2012 00:23:25 +0200")
On 28 Jun 2012, Francois Romieu stated:
> Nix <nix@esperi.org.uk> :
>> Francois Romieu <romieu@fr.zoreil.com> :
>> > Can you try and revert 036dafa28da1e2565a8529de2ae663c37b7a0060 ?
>>
>> I can try, but there's been a *lot* of code motion since then, 'git
>> revert' fails hilariously (trying to patch obviously the wrong places):
>> I'll have to do it by hand.
>
> There is a single line reject in rtl8169_start_xmit. Other than that it
> should patch -p1 -R fine.
... and indeed it does. Weird, why does git revert fail so badly when
patch and git apply are both happy?!
I'll reboot into this kernel tomorrow, and report back in a few days (or
sooner if it goes wrong).
>> [ 1.341389] r8169 0000:06:00.0: eth0: jumbo features [frames: 6128 bytes, tx checksumming: ko]
>
> This chipset is not supposed to be pushed beyond 6128 bytes.
Interesting. It's always worked flawlessly at 7200 for me before, until,
uh, last year when it stopped working and I never noticed (in fact
a 7200-byte MTU was how the machine was shipped to me :) ).
I guess I'll knock it down to 6128 then, less than 1000 bytes isn't
going to ruin performance by any means...
... aand that works. thanks! (Let's see if the link stuttering continues. I
expect it will, though it's been three hours since the last stutter...)
--
NULL && (void)
next prev parent reply other threads:[~2012-06-28 23:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 16:15 3.4.x regression: rtl8169: frequent resets Nix
2012-06-28 19:30 ` Francois Romieu
2012-06-28 21:12 ` Nix
2012-06-28 22:23 ` Francois Romieu
2012-06-28 23:10 ` Nix [this message]
2012-06-28 23:31 ` Stefan Lippers-Hollmann
2012-06-28 23:42 ` Nix
2012-06-29 11:50 ` Stefan Lippers-Hollmann
2012-07-02 0:43 ` Stefan Lippers-Hollmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bok3oww6.fsf@spindle.srvr.nix \
--to=nix@esperi.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox