* [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT
@ 2010-05-24 8:25 Li Zefan
2010-05-25 3:36 ` Steven Rostedt
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Li Zefan @ 2010-05-24 8:25 UTC (permalink / raw)
To: Eric Anholt
Cc: airlied, chris, Frederic Weisbecker, Steven Rostedt, LKML,
dri-devel
Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K:
text data bss dec hex filename
13204 2732 12 15948 3e4c i915_trace_points.o.orig
12668 2732 12 15412 3c34 i915_trace_points.o
No change in functionality.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
drivers/gpu/drm/i915/i915_trace.h | 24 +++++++-----------------
1 files changed, 7 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
index 9e4c45f..fab2176 100644
--- a/drivers/gpu/drm/i915/i915_trace.h
+++ b/drivers/gpu/drm/i915/i915_trace.h
@@ -53,23 +53,6 @@ TRACE_EVENT(i915_gem_object_bind,
__entry->obj, __entry->gtt_offset)
);
-TRACE_EVENT(i915_gem_object_clflush,
-
- TP_PROTO(struct drm_gem_object *obj),
-
- TP_ARGS(obj),
-
- TP_STRUCT__entry(
- __field(struct drm_gem_object *, obj)
- ),
-
- TP_fast_assign(
- __entry->obj = obj;
- ),
-
- TP_printk("obj=%p", __entry->obj)
-);
-
TRACE_EVENT(i915_gem_object_change_domain,
TP_PROTO(struct drm_gem_object *obj, uint32_t old_read_domains, uint32_t old_write_domain),
@@ -132,6 +115,13 @@ DECLARE_EVENT_CLASS(i915_gem_object,
TP_printk("obj=%p", __entry->obj)
);
+DEFINE_EVENT(i915_gem_object, i915_gem_object_clflush,
+
+ TP_PROTO(struct drm_gem_object *obj),
+
+ TP_ARGS(obj)
+);
+
DEFINE_EVENT(i915_gem_object, i915_gem_object_unbind,
TP_PROTO(struct drm_gem_object *obj),
--
1.6.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT
2010-05-24 8:25 [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT Li Zefan
@ 2010-05-25 3:36 ` Steven Rostedt
2010-05-25 20:08 ` Steven Rostedt
2010-05-26 20:49 ` Eric Anholt
2 siblings, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2010-05-25 3:36 UTC (permalink / raw)
To: Li Zefan
Cc: Eric Anholt, airlied, chris, Frederic Weisbecker, LKML, dri-devel
On Mon, 2010-05-24 at 16:25 +0800, Li Zefan wrote:
> Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K:
>
> text data bss dec hex filename
> 13204 2732 12 15948 3e4c i915_trace_points.o.orig
> 12668 2732 12 15412 3c34 i915_trace_points.o
>
> No change in functionality.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> ---
> drivers/gpu/drm/i915/i915_trace.h | 24 +++++++-----------------
> 1 files changed, 7 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 9e4c45f..fab2176 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -53,23 +53,6 @@ TRACE_EVENT(i915_gem_object_bind,
> __entry->obj, __entry->gtt_offset)
> );
>
> -TRACE_EVENT(i915_gem_object_clflush,
> -
> - TP_PROTO(struct drm_gem_object *obj),
> -
> - TP_ARGS(obj),
> -
> - TP_STRUCT__entry(
> - __field(struct drm_gem_object *, obj)
> - ),
> -
> - TP_fast_assign(
> - __entry->obj = obj;
> - ),
> -
> - TP_printk("obj=%p", __entry->obj)
> -);
> -
> TRACE_EVENT(i915_gem_object_change_domain,
>
> TP_PROTO(struct drm_gem_object *obj, uint32_t old_read_domains, uint32_t old_write_domain),
> @@ -132,6 +115,13 @@ DECLARE_EVENT_CLASS(i915_gem_object,
> TP_printk("obj=%p", __entry->obj)
> );
>
> +DEFINE_EVENT(i915_gem_object, i915_gem_object_clflush,
> +
> + TP_PROTO(struct drm_gem_object *obj),
> +
> + TP_ARGS(obj)
> +);
> +
> DEFINE_EVENT(i915_gem_object, i915_gem_object_unbind,
>
> TP_PROTO(struct drm_gem_object *obj),
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT
2010-05-24 8:25 [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT Li Zefan
2010-05-25 3:36 ` Steven Rostedt
@ 2010-05-25 20:08 ` Steven Rostedt
2010-05-26 19:00 ` Eric Anholt
2010-05-26 20:49 ` Eric Anholt
2 siblings, 1 reply; 5+ messages in thread
From: Steven Rostedt @ 2010-05-25 20:08 UTC (permalink / raw)
To: Li Zefan
Cc: Eric Anholt, airlied, chris, Frederic Weisbecker, LKML, dri-devel
On Mon, 2010-05-24 at 16:25 +0800, Li Zefan wrote:
> Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K:
>
> text data bss dec hex filename
> 13204 2732 12 15948 3e4c i915_trace_points.o.orig
> 12668 2732 12 15412 3c34 i915_trace_points.o
>
> No change in functionality.
>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
I'm expecting that this will be going through the DRM/i915 path.
-- Steve
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> drivers/gpu/drm/i915/i915_trace.h | 24 +++++++-----------------
> 1 files changed, 7 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index 9e4c45f..fab2176 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -53,23 +53,6 @@ TRACE_EVENT(i915_gem_object_bind,
> __entry->obj, __entry->gtt_offset)
> );
>
> -TRACE_EVENT(i915_gem_object_clflush,
> -
> - TP_PROTO(struct drm_gem_object *obj),
> -
> - TP_ARGS(obj),
> -
> - TP_STRUCT__entry(
> - __field(struct drm_gem_object *, obj)
> - ),
> -
> - TP_fast_assign(
> - __entry->obj = obj;
> - ),
> -
> - TP_printk("obj=%p", __entry->obj)
> -);
> -
> TRACE_EVENT(i915_gem_object_change_domain,
>
> TP_PROTO(struct drm_gem_object *obj, uint32_t old_read_domains, uint32_t old_write_domain),
> @@ -132,6 +115,13 @@ DECLARE_EVENT_CLASS(i915_gem_object,
> TP_printk("obj=%p", __entry->obj)
> );
>
> +DEFINE_EVENT(i915_gem_object, i915_gem_object_clflush,
> +
> + TP_PROTO(struct drm_gem_object *obj),
> +
> + TP_ARGS(obj)
> +);
> +
> DEFINE_EVENT(i915_gem_object, i915_gem_object_unbind,
>
> TP_PROTO(struct drm_gem_object *obj),
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT
2010-05-25 20:08 ` Steven Rostedt
@ 2010-05-26 19:00 ` Eric Anholt
0 siblings, 0 replies; 5+ messages in thread
From: Eric Anholt @ 2010-05-26 19:00 UTC (permalink / raw)
To: rostedt, Li Zefan; +Cc: airlied, chris, Frederic Weisbecker, LKML, dri-devel
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Tue, 25 May 2010 16:08:46 -0400, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 2010-05-24 at 16:25 +0800, Li Zefan wrote:
> > Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K:
> >
> > text data bss dec hex filename
> > 13204 2732 12 15948 3e4c i915_trace_points.o.orig
> > 12668 2732 12 15412 3c34 i915_trace_points.o
> >
> > No change in functionality.
> >
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> I'm expecting that this will be going through the DRM/i915 path.
Yeah.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT
2010-05-24 8:25 [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT Li Zefan
2010-05-25 3:36 ` Steven Rostedt
2010-05-25 20:08 ` Steven Rostedt
@ 2010-05-26 20:49 ` Eric Anholt
2 siblings, 0 replies; 5+ messages in thread
From: Eric Anholt @ 2010-05-26 20:49 UTC (permalink / raw)
To: Li Zefan
Cc: airlied, chris, Frederic Weisbecker, Steven Rostedt, LKML,
dri-devel
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
On Mon, 24 May 2010 16:25:44 +0800, Li Zefan <lizf@cn.fujitsu.com> wrote:
> Convert i915_gem_object_clflush to DEFINE_EVENT, and save ~0.5K:
>
> text data bss dec hex filename
> 13204 2732 12 15948 3e4c i915_trace_points.o.orig
> 12668 2732 12 15412 3c34 i915_trace_points.o
>
> No change in functionality.
Applied. Thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-26 20:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-24 8:25 [PATCH] drm/i915: Convert more trace events to DEFINE_EVENT Li Zefan
2010-05-25 3:36 ` Steven Rostedt
2010-05-25 20:08 ` Steven Rostedt
2010-05-26 19:00 ` Eric Anholt
2010-05-26 20:49 ` Eric Anholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox