From: Andi Kleen <andi@firstfloor.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Christian Kujau <lists@nerdbynature.de>,
Alexander Beregalov <a.beregalov@gmail.com>,
Chris Mason <chris.mason@oracle.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [GIT PULL] reiserfs fixes
Date: Sat, 02 Jan 2010 14:41:51 +0100 [thread overview]
Message-ID: <87bphc7heo.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1262395636-8647-1-git-send-regression-fweisbec@gmail.com> (Frederic Weisbecker's message of "Sat, 2 Jan 2010 02:27:16 +0100")
Frederic Weisbecker <fweisbec@gmail.com> writes:
>
> That's why you'll mostly find dependency inversion fixes based on
> such pattern:
>
> reiserfs_write_unlock()
> mutex_lock(random_lock)
> reiserfs_write_lock()
These `workarounds' look rather ugly and are likely much slower
than the BKL that was there before. Perhaps it's better to simply
go back to the BKL until this can be all fixed properly
(or a more faithful emulation for the BKL can be devised)?
>
> This is not beautiful but at least that's better than the bkl.
>
> Oh and I expect other lock inversions will get reported in
> the future due to rare and then yet untested paths.
... and given that was the conversion really a good idea?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-02 13:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 1:27 [GIT PULL] reiserfs fixes Frederic Weisbecker
2010-01-02 13:41 ` Andi Kleen [this message]
2010-01-02 16:36 ` Frederic Weisbecker
2010-01-02 17:43 ` reiserfs broken in 2.6.32 was " Andi Kleen
2010-01-02 19:02 ` Frederic Weisbecker
2010-01-02 19:23 ` Andi Kleen
2010-01-02 20:11 ` Frederic Weisbecker
2010-01-02 20:33 ` Andi Kleen
2010-01-02 20:54 ` Frederic Weisbecker
2010-01-02 21:10 ` Ingo Molnar
2010-01-02 21:42 ` Ingo Molnar
2010-01-02 21:01 ` tytso
2010-01-02 21:06 ` Frederic Weisbecker
2010-01-02 23:36 ` tytso
2010-01-02 23:43 ` Christian Kujau
2010-01-03 1:16 ` Frederic Weisbecker
2010-01-03 1:52 ` Frederic Weisbecker
2010-01-03 2:05 ` Christian Kujau
2010-01-03 3:27 ` tytso
2010-01-04 20:20 ` Frederic Weisbecker
2010-01-02 20:11 ` Ingo Molnar
2010-01-02 22:18 ` Ingo Molnar
2010-01-02 19:19 ` Linus Torvalds
2010-01-02 19:21 ` Linus Torvalds
2010-01-02 19:24 ` Frederic Weisbecker
2010-01-02 19:22 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2010-02-14 18:14 Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bphc7heo.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=a.beregalov@gmail.com \
--cc=chris.mason@oracle.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox