From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764685AbZLQMza (ORCPT ); Thu, 17 Dec 2009 07:55:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764571AbZLQMz2 (ORCPT ); Thu, 17 Dec 2009 07:55:28 -0500 Received: from one.firstfloor.org ([213.235.205.2]:49105 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764413AbZLQMzJ (ORCPT ); Thu, 17 Dec 2009 07:55:09 -0500 To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Wu Fengguang , Andi Kleen , Peter Zijlstra , Andrew Morton , Matt Mackall , Nick Piggin , Christoph Lameter , Fr??d??ric Weisbecker , Steven Rostedt , Thomas Gleixner Subject: Re: -tip: origin tree build failure From: Andi Kleen References: <20091217094041.GA24708@elte.hu> <20091217122316.GB14088@elte.hu> Date: Thu, 17 Dec 2009 13:55:04 +0100 In-Reply-To: <20091217122316.GB14088@elte.hu> (Ingo Molnar's message of "Thu, 17 Dec 2009 13:23:16 +0100") Message-ID: <87bphxu5ef.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar writes: > * Ingo Molnar wrote: > >> config MEMORY_FAILURE >> depends on MMU >> depends on ARCH_SUPPORTS_MEMORY_FAILURE >> + select PROC_PAGE_MONITOR >> bool "Enable recovery from hardware memory errors" > > It also needs to depend on PROC_FS in that case - as per the updated patch > below. Thanks for the report. MEMORY_FAILURE itself doesn't depend on the page flags, just the injector which has a separate config option. It already has a select PROC_PAGE_MONITOR, but the proc dependency is indeed missing. I think the correct fix is the appended patch. -Andi --- HWPOISON: Add PROC_FS dependency to hwpoison injector The injector filter requires stable_page_flags() which is supplied by procfs. So make it dependent on that. Reported by Ingo Molnar Signed-off-by: Andi Kleen --- mm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/mm/Kconfig =================================================================== --- linux.orig/mm/Kconfig +++ linux/mm/Kconfig @@ -252,7 +252,7 @@ config MEMORY_FAILURE config HWPOISON_INJECT tristate "HWPoison pages injector" - depends on MEMORY_FAILURE && DEBUG_KERNEL + depends on MEMORY_FAILURE && DEBUG_KERNEL && PROC_FS select PROC_PAGE_MONITOR config NOMMU_INITIAL_TRIM_EXCESS