From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B4B73A7305; Thu, 22 Jan 2026 16:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769098209; cv=none; b=MeUbl6Qa/YDedbhjiVq6/geL5xSFrAoIQBr4oi3AEX6/fbG7maLSJMovlBOKRmeQvKlDL4hbaVcxUtMEsykoTvUFwFaDZG/giZCvADzvvMhUsOR2dsJi1pCY20zuvYapr9KRiqLxYnTaKbljDcsmdJySJ/9MRL3HkBcBZnO/u1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769098209; c=relaxed/simple; bh=k7QW3qPKlTntPWlZbEnFujv5B/X+vJaJYGTzqWriX0E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gbAKogvDPfegr0kzX8UygCDXuTnF6i+BcNoQt2S+ymw/OzjBPR1CFJLccTQjzcHKsa8xRgA0DYew6LxtLSsHt3Q8nxJWp7pFFjoPot37jb3oHAmRnkHNESqkPPfjYgDR/AeOul0GN0lTK4Q3De2J0CV9xBep00926bKFAGYPizI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=GChQ+vEi; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="GChQ+vEi" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id BA5A71A2ABF; Thu, 22 Jan 2026 16:10:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8B53560711; Thu, 22 Jan 2026 16:10:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 09487119A836B; Thu, 22 Jan 2026 17:09:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769098199; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=foXvwYKbYB8CyKEYmZ4+Fr8gBVI1/yFp9iUKgNiyQ0I=; b=GChQ+vEiWnYyfng9HTHtiOKy6C18v4CXN/G5K3X4JkgfXLGiZpjLkQq0pCFI5lHExcS5VE /Mt6uNde8abCqUd0/ztnyplmplLJ+RXF5o3nt5MGZCbMZRT/vYSVSI/3+sJ++k3nC/2N3+ TGkCeyaxom5wizhxTNLPgLS2hcXmL4AA3oWzI0MtAXR8G6AZ4XLCDeDQfxQSYfLKg14T4j QbaQnavUKZl9LwpNTfyatjJ0iw9vLUFnv0I5Dbskv/jKgCSSDqtKa+uaS8LxCYbmW1c7gh 0NbuZxCG1vHfNUjOeuy1Mdqh5Hrd07CWG/GphlLmrT180epC0vgEwDwdznfU1g== From: Gregory CLEMENT To: Elad Nachman , "Rob Herring (Arm)" , Andrew Lunn , Sebastian Hesselbarth , Krzysztof Kozlowski , Conor Dooley Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [EXTERNAL] Re: [PATCH] arm/arm64: dts: marvell: Drop unused .dtsi In-Reply-To: References: <20260113200744.4174940-1-robh@kernel.org> <87fr7yklud.fsf@BLaptop.bootlin.com> Date: Thu, 22 Jan 2026 17:09:55 +0100 Message-ID: <87cy31ljcc.fsf@BLaptop.bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Elad Nachman writes: > Hi, > >>=20 >>=20 >> From: Gregory CLEMENT >> Sent: Thursday, January 22, 2026 12:01 PM >> To: Rob Herring (Arm) ; Andrew Lunn ; S= ebastian Hesselbarth ; Krzysztof Kozlowski= ; Conor Dooley ; Elad Nachman >> Cc: linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; li= nux-kernel@vger.kernel.org >> Subject: [EXTERNAL] Re: [PATCH] arm/arm64: dts: marvell: Drop unused .dt= si >>=20 >> Hello Rob, >> > These .dtsi files are not included anywhere in the tree and can't be >> > tested. >> > > Signed-off-by: Rob Herring (Arm) = > --- >> > arch/arm/boot/dts/marvell/armada-380.=E2=80=8Adtsi | 148 >> Hello Rob, >>=20 >> > These .dtsi files are not included anywhere in the tree and can't be >> > tested. >> > >> > Signed-off-by: Rob Herring (Arm) >> > --- >> > arch/arm/boot/dts/marvell/armada-380.dtsi | 148 ------------------ >> > arch/arm64/boot/dts/marvell/armada-7020.dtsi | 10 -- >> > arch/arm64/boot/dts/marvell/armada-8020.dtsi | 20 --- >> > .../boot/dts/marvell/armada-ap806-dual.dtsi | 60 ------- >>=20 >> For these ones I agree removing them > > armada-7020.dtsi uses armada-ap806-dual.dtsi > armada-7020.dtsi is used by several of our boards, I have submitted the f= ollowing commit: > https://lkml.org/lkml/2023/12/18/1024 > But for some reason I did not get any response for it. > If we merge it, these two DTSI files (7020 and ap806-dual) will be > used. Even in the lore, it is not easy to find these emails, and indeed I missed them while I merged the previous series sent. Could you rebase and send it again ? Gregory > >>=20 >> > .../dts/marvell/cn9130-db-comexpress.dtsi | 96 ------------ >>=20 >> I am a bit more concerned about this one, as it really seems to be an >> existing module. I would like to get feedback from Elad Nachman, who >> submitted it, to find out if there is any dts board that can be >> submitted to keep this dtsi or, conversely, if we can indeed remove the >> dtsi. > > Currently we only have a Com-Express board for CN9131, so for now you can= drop this one. > >>=20 >> Gregory >>=20 >> > 5 files changed, 334 deletions(-) >> > delete mode 100644 arch/arm/boot/dts/marvell/armada-380.dtsi >> > delete mode 100644 arch/arm64/boot/dts/marvell/armada-7020.dtsi >> > delete mode 100644 arch/arm64/boot/dts/marvell/armada-8020.dtsi >> > delete mode 100644 arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi >> > delete mode 100644 arch/arm64/boot/dts/marvell/cn9130-db-comexpress.d= tsi >> > >> > diff --git a/arch/arm/boot/dts/marvell/armada-380.dtsi b/arch/arm/boot= /dts/marvell/armada-380.dtsi >> > deleted file mode 100644 >> > index e94f22b0e9b5..000000000000 >> > --- a/arch/arm/boot/dts/marvell/armada-380.dtsi >> > +++ /dev/null >> > @@ -1,148 +0,0 @@ >> > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> > -/* >> > - * Device Tree Include file for Marvell Armada 380 SoC. >> > - * >> > - * Copyright (C) 2014 Marvell >> > - * >> > - * Lior Amsalem >> > - * Gregory CLEMENT >> > - * Thomas Petazzoni >> > - */ >> > - >> > -#include "armada-38x.dtsi" >> > - >> > -/ { >> > - model =3D "Marvell Armada 380 family SoC"; >> > - compatible =3D "marvell,armada380"; >> > - >> > - cpus { >> > - #address-cells =3D <1>; >> > - #size-cells =3D <0>; >> > - enable-method =3D "marvell,armada-380-smp"; >> > - >> > - cpu@0 { >> > - device_type =3D "cpu"; >> > - compatible =3D "arm,cortex-a9"; >> > - reg =3D <0>; >> > - }; >> > - }; >> > - >> > - soc { >> > - internal-regs { >> > - pinctrl@18000 { >> > - compatible =3D "marvell,mv88f6810-pinctrl"; >> > - }; >> > - }; >> > - >> > - pcie { >> > - compatible =3D "marvell,armada-370-pcie"; >> > - status =3D "disabled"; >> > - device_type =3D "pci"; >> > - >> > - #address-cells =3D <3>; >> > - #size-cells =3D <2>; >> > - >> > - msi-parent =3D <&mpic>; >> > - bus-range =3D <0x00 0xff>; >> > - >> > - ranges =3D >> > - <0x82000000 0 0x80000 MBUS_ID(0xf0, 0x01) 0x80000 0 0x00002= 000 >> > - 0x82000000 0 0x40000 MBUS_ID(0xf0, 0x01) 0x40000 0 0x00002000 >> > - 0x82000000 0 0x44000 MBUS_ID(0xf0, 0x01) 0x44000 0 0x00002000 >> > - 0x82000000 0 0x48000 MBUS_ID(0xf0, 0x01) 0x48000 0 0x00002000 >> > - 0x82000000 0x1 0 MBUS_ID(0x08, 0xe8) 0 1 0 /* Port 0 MEM */ >> > - 0x81000000 0x1 0 MBUS_ID(0x08, 0xe0) 0 1 0 /* Port 0 IO */ >> > - 0x82000000 0x2 0 MBUS_ID(0x04, 0xe8) 0 1 0 /* Port 1 MEM */ >> > - 0x81000000 0x2 0 MBUS_ID(0x04, 0xe0) 0 1 0 /* Port 1 IO */ >> > - 0x82000000 0x3 0 MBUS_ID(0x04, 0xd8) 0 1 0 /* Port 2 MEM */ >> > - 0x81000000 0x3 0 MBUS_ID(0x04, 0xd0) 0 1 0 /* Port 2 IO */>; >> > - >> > - /* x1 port */ >> > - pcie@1,0 { >> > - device_type =3D "pci"; >> > - assigned-addresses =3D <0x82000800 0 0x80000 0 0x2000>; >> > - reg =3D <0x0800 0 0 0 0>; >> > - #address-cells =3D <3>; >> > - #size-cells =3D <2>; >> > - interrupt-names =3D "intx"; >> > - interrupts-extended =3D <&gic GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>; >> > - #interrupt-cells =3D <1>; >> > - ranges =3D <0x82000000 0 0 0x82000000 0x1 0 1 0 >> > - 0x81000000 0 0 0x81000000 0x1 0 1 0>; >> > - bus-range =3D <0x00 0xff>; >> > - interrupt-map-mask =3D <0 0 0 7>; >> > - interrupt-map =3D <0 0 0 1 &pcie1_intc 0>, >> > - <0 0 0 2 &pcie1_intc 1>, >> > - <0 0 0 3 &pcie1_intc 2>, >> > - <0 0 0 4 &pcie1_intc 3>; >> > - marvell,pcie-port =3D <0>; >> > - marvell,pcie-lane =3D <0>; >> > - clocks =3D <&gateclk 8>; >> > - status =3D "disabled"; >> > - >> > - pcie1_intc: interrupt-controller { >> > - interrupt-controller; >> > - #interrupt-cells =3D <1>; >> > - }; >> > - }; >> > - >> > - /* x1 port */ >> > - pcie@2,0 { >> > - device_type =3D "pci"; >> > - assigned-addresses =3D <0x82001000 0 0x40000 0 0x2000>; >> > - reg =3D <0x1000 0 0 0 0>; >> > - #address-cells =3D <3>; >> > - #size-cells =3D <2>; >> > - interrupt-names =3D "intx"; >> > - interrupts-extended =3D <&gic GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>; >> > - #interrupt-cells =3D <1>; >> > - ranges =3D <0x82000000 0 0 0x82000000 0x2 0 1 0 >> > - 0x81000000 0 0 0x81000000 0x2 0 1 0>; >> > - bus-range =3D <0x00 0xff>; >> > - interrupt-map-mask =3D <0 0 0 7>; >> > - interrupt-map =3D <0 0 0 1 &pcie2_intc 0>, >> > - <0 0 0 2 &pcie2_intc 1>, >> > - <0 0 0 3 &pcie2_intc 2>, >> > - <0 0 0 4 &pcie2_intc 3>; >> > - marvell,pcie-port =3D <1>; >> > - marvell,pcie-lane =3D <0>; >> > - clocks =3D <&gateclk 5>; >> > - status =3D "disabled"; >> > - >> > - pcie2_intc: interrupt-controller { >> > - interrupt-controller; >> > - #interrupt-cells =3D <1>; >> > - }; >> > - }; >> > - >> > - /* x1 port */ >> > - pcie@3,0 { >> > - device_type =3D "pci"; >> > - assigned-addresses =3D <0x82001800 0 0x44000 0 0x2000>; >> > - reg =3D <0x1800 0 0 0 0>; >> > - #address-cells =3D <3>; >> > - #size-cells =3D <2>; >> > - interrupt-names =3D "intx"; >> > - interrupts-extended =3D <&gic GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>; >> > - #interrupt-cells =3D <1>; >> > - ranges =3D <0x82000000 0 0 0x82000000 0x3 0 1 0 >> > - 0x81000000 0 0 0x81000000 0x3 0 1 0>; >> > - bus-range =3D <0x00 0xff>; >> > - interrupt-map-mask =3D <0 0 0 7>; >> > - interrupt-map =3D <0 0 0 1 &pcie3_intc 0>, >> > - <0 0 0 2 &pcie3_intc 1>, >> > - <0 0 0 3 &pcie3_intc 2>, >> > - <0 0 0 4 &pcie3_intc 3>; >> > - marvell,pcie-port =3D <2>; >> > - marvell,pcie-lane =3D <0>; >> > - clocks =3D <&gateclk 6>; >> > - status =3D "disabled"; >> > - >> > - pcie3_intc: interrupt-controller { >> > - interrupt-controller; >> > - #interrupt-cells =3D <1>; >> > - }; >> > - }; >> > - }; >> > - }; >> > -}; >> > diff --git a/arch/arm64/boot/dts/marvell/armada-7020.dtsi b/arch/arm64= /boot/dts/marvell/armada-7020.dtsi >> > deleted file mode 100644 >> > index 570f901b4f4a..000000000000 >> > --- a/arch/arm64/boot/dts/marvell/armada-7020.dtsi >> > +++ /dev/null >> > @@ -1,10 +0,0 @@ >> > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> > -/* >> > - * Copyright (C) 2016 Marvell Technology Group Ltd. >> > - * >> > - * Device Tree file for the Armada 7020 SoC, made of an AP806 Dual and >> > - * one CP110. >> > - */ >> > - >> > -#include "armada-ap806-dual.dtsi" >> > -#include "armada-70x0.dtsi" >> > diff --git a/arch/arm64/boot/dts/marvell/armada-8020.dtsi b/arch/arm64= /boot/dts/marvell/armada-8020.dtsi >> > deleted file mode 100644 >> > index b6fc18876093..000000000000 >> > --- a/arch/arm64/boot/dts/marvell/armada-8020.dtsi >> > +++ /dev/null >> > @@ -1,20 +0,0 @@ >> > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> > -/* >> > - * Copyright (C) 2016 Marvell Technology Group Ltd. >> > - * >> > - * Device Tree file for the Armada 8020 SoC, made of an AP806 Dual and >> > - * two CP110. >> > - */ >> > - >> > -#include "armada-ap806-dual.dtsi" >> > -#include "armada-80x0.dtsi" >> > - >> > -/* The RTC requires external oscillator. But on Aramda 80x0, the RTC = clock >> > - * in CP master is not connected (by package) to the oscillator. So >> > - * disable it. However, the RTC clock in CP slave is connected to the >> > - * oscillator so this one is let enabled. >> > - */ >> > - >> > -&cp0_rtc { >> > - status =3D "disabled"; >> > -}; >> > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi b/arch= /arm64/boot/dts/marvell/armada-ap806-dual.dtsi >> > deleted file mode 100644 >> > index 82f4dedfc25e..000000000000 >> > --- a/arch/arm64/boot/dts/marvell/armada-ap806-dual.dtsi >> > +++ /dev/null >> > @@ -1,60 +0,0 @@ >> > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> > -/* >> > - * Copyright (C) 2016 Marvell Technology Group Ltd. >> > - * >> > - * Device Tree file for Marvell Armada AP806. >> > - */ >> > - >> > -#include "armada-ap806.dtsi" >> > - >> > -/ { >> > - cpus { >> > - #address-cells =3D <1>; >> > - #size-cells =3D <0>; >> > - >> > - cpu0: cpu@0 { >> > - device_type =3D "cpu"; >> > - compatible =3D "arm,cortex-a72"; >> > - reg =3D <0x000>; >> > - enable-method =3D "psci"; >> > - #cooling-cells =3D <2>; >> > - clocks =3D <&cpu_clk 0>; >> > - i-cache-size =3D <0xc000>; >> > - i-cache-line-size =3D <64>; >> > - i-cache-sets =3D <256>; >> > - d-cache-size =3D <0x8000>; >> > - d-cache-line-size =3D <64>; >> > - d-cache-sets =3D <256>; >> > - next-level-cache =3D <&l2>; >> > - }; >> > - cpu1: cpu@1 { >> > - device_type =3D "cpu"; >> > - compatible =3D "arm,cortex-a72"; >> > - reg =3D <0x001>; >> > - enable-method =3D "psci"; >> > - #cooling-cells =3D <2>; >> > - clocks =3D <&cpu_clk 0>; >> > - i-cache-size =3D <0xc000>; >> > - i-cache-line-size =3D <64>; >> > - i-cache-sets =3D <256>; >> > - d-cache-size =3D <0x8000>; >> > - d-cache-line-size =3D <64>; >> > - d-cache-sets =3D <256>; >> > - next-level-cache =3D <&l2>; >> > - }; >> > - >> > - l2: l2-cache { >> > - compatible =3D "cache"; >> > - cache-size =3D <0x80000>; >> > - cache-line-size =3D <64>; >> > - cache-sets =3D <512>; >> > - cache-level =3D <2>; >> > - cache-unified; >> > - }; >> > - }; >> > - >> > - thermal-zones { >> > - /delete-node/ ap-thermal-cpu2; >> > - /delete-node/ ap-thermal-cpu3; >> > - }; >> > -}; >> > diff --git a/arch/arm64/boot/dts/marvell/cn9130-db-comexpress.dtsi b/a= rch/arm64/boot/dts/marvell/cn9130-db-comexpress.dtsi >> > deleted file mode 100644 >> > index 028496ebc473..000000000000 >> > --- a/arch/arm64/boot/dts/marvell/cn9130-db-comexpress.dtsi >> > +++ /dev/null >> > @@ -1,96 +0,0 @@ >> > -// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> > -/* >> > - * Copyright (C) 2023 Marvell International Ltd. >> > - * >> > - * Device tree for the CN9130-DB Com Express CPU module board. >> > - */ >> > - >> > -#include "cn9130-db.dtsi" >> > - >> > -/ { >> > - model =3D "Marvell Armada CN9130-DB COM EXPRESS type 7 CPU module bo= ard"; >> > - compatible =3D "marvell,cn9130-cpu-module", "marvell,cn9130", >> > - "marvell,armada-ap807-quad", "marvell,armada-ap807"; >> > - >> > -}; >> > - >> > -&ap0_reg_sd_vccq { >> > - regulator-max-microvolt =3D <1800000>; >> > - states =3D <1800000 0x1 1800000 0x0>; >> > - /delete-property/ gpios; >> > -}; >> > - >> > -&cp0_reg_usb3_vbus0 { >> > - /delete-property/ gpio; >> > -}; >> > - >> > -&cp0_reg_usb3_vbus1 { >> > - /delete-property/ gpio; >> > -}; >> > - >> > -&cp0_reg_sd_vcc { >> > - status =3D "disabled"; >> > -}; >> > - >> > -&cp0_reg_sd_vccq { >> > - status =3D "disabled"; >> > -}; >> > - >> > -&cp0_sdhci0 { >> > - status =3D "disabled"; >> > -}; >> > - >> > -&cp0_eth0 { >> > - status =3D "disabled"; >> > -}; >> > - >> > -&cp0_eth1 { >> > - status =3D "okay"; >> > - phy =3D <&phy0>; >> > - phy-mode =3D "rgmii-id"; >> > -}; >> > - >> > -&cp0_eth2 { >> > - status =3D "disabled"; >> > -}; >> > - >> > -&cp0_mdio { >> > - status =3D "okay"; >> > - pinctrl-0 =3D <&cp0_ge_mdio_pins>; >> > - phy0: ethernet-phy@0 { >> > - status =3D "okay"; >> > - }; >> > -}; >> > - >> > -&cp0_syscon0 { >> > - cp0_pinctrl: pinctrl { >> > - compatible =3D "marvell,cp115-standalone-pinctrl"; >> > - >> > - cp0_ge_mdio_pins: ge-mdio-pins { >> > - marvell,pins =3D "mpp40", "mpp41"; >> > - marvell,function =3D "ge"; >> > - }; >> > - }; >> > -}; >> > - >> > -&cp0_sdhci0 { >> > - status =3D "disabled"; >> > -}; >> > - >> > -&cp0_spi1 { >> > - status =3D "okay"; >> > -}; >> > - >> > -&cp0_usb3_0 { >> > - status =3D "okay"; >> > - usb-phy =3D <&cp0_usb3_0_phy0>; >> > - phy-names =3D "usb"; >> > - /delete-property/ phys; >> > -}; >> > - >> > -&cp0_usb3_1 { >> > - status =3D "okay"; >> > - usb-phy =3D <&cp0_usb3_0_phy1>; >> > - phy-names =3D "usb"; >> > - /delete-property/ phys; >> > -}; >> > -- >> > 2.51.0 >> > >>=20 >> -- >> Gr=C3=A9gory CLEMENT, Bootlin >> Embedded Linux and Kernel engineering > > Thanks, > > Elad. --=20 Gr=C3=A9gory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com