From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AE0434A76D for ; Tue, 16 Dec 2025 08:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872489; cv=none; b=OCL0LlXD9fmick1PKDK8LAOyU7zaMh7xeXnSXXXUeQu2AAg4eB2oXWdu2QGdQWoEzV0jFkhne7wTOLQG5brV/iL5XIdNPHXm4D4uHC3qkTlvjpzeLMJp+NPrsR4hpRmxVNtSfdUFroQg10kzNow8AzY6JyRpxp2WCz2d/rg1zRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872489; c=relaxed/simple; bh=RHz8iH3yLjZSj3vhUgRlWaweVH1IO38WEpnpNpCWtgA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HeRhcvYtEaNBZ4MMWMuF7+CNpKnhN/XShTHiUQFZ+ow/5EZVf8anxCd0t3uxYJzWQpQw7Zc9bJ+HmJLVbX0CXQgbw6YTE08F+wpW6DT8kRF6EyZ/XM6Py2dzHvHPTrldFOlD7zxeVnzNThEwFs6P/IlLVftLjp0HTVEf/Y0feCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=pf8rxSBG; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="pf8rxSBG" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 28D4DC19D2F; Tue, 16 Dec 2025 08:07:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 881E36072F; Tue, 16 Dec 2025 08:08:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 611A911942FCC; Tue, 16 Dec 2025 09:07:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765872480; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=RHz8iH3yLjZSj3vhUgRlWaweVH1IO38WEpnpNpCWtgA=; b=pf8rxSBGLIO6tuV5JQC9qcHmqClcrsTpkL+mjX1APgXfZGJg8MuOFEbnNzoZ4UqhWXdNBB jpYx2iPanodMtIGjc6JlQgWPdIdWguSOZEREeQSRbJ1amvlpcfL5jotnrhwfvk4XbS5oj0 pxG8w4QgTMv5jhvoYNGW1t9QPmYSSN14EKI3Aw6azBhTvYTWYes+XQw3lz+5LwgYn8chUT +t7ouYrg0VGpnkP18Xx/s/4BveZNnIFsML5oTfJKnDfD21euxVz3oXp3udcVG6py2ulN/y VVnn4jff45o3IsaAR8pVshhOc41CBw+PHLq20eaIN+q+L7/c5f8dWIKBgfp/iQ== From: Miquel Raynal To: George Moussalem Cc: Ziyang Huang , quic_mdalam@quicinc.com, richard@nod.at, vigneshr@ti.com, tudor.ambarus@linaro.org, mmkurbanov@salutedevices.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "mtd: spinand: esmt: fix id code for F50D1G41LB" In-Reply-To: (George Moussalem's message of "Mon, 8 Dec 2025 13:26:21 +0400") References: <87wm2x74pz.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 16 Dec 2025 09:07:56 +0100 Message-ID: <87cy4esvc3.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hi, >>> This reverts commit dd26402642a0899fde59ea6b0852fad3d799b4cc. >>> >>> The issue George met is due to the limit of QPIC, not the issue of the >>> flash chip. >>> >>> QPIC only supports 4 bytes ID. So the fifth byte is always 0. >>> >>> If we use spi-gpio, the fifth byte can be read correctly. >>> >>> Signed-off-by: Ziyang Huang >>> --- >>=20 >> So how do we solve that? >>=20 >> Is there anything than can be done on the qpic side? > > Hi Alam, > > Is the hardware itself limited to reading 4 ID bytes only or is it a > driver limitation? FYI I will pick the revert, because indeed the original fix is wrong and any device with 5 ID bytes would need a similar change (which is not possible), and let you figure out a quirk for the Qpic driver. Thanks, Miqu=C3=A8l