From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084A1280CF1; Fri, 12 Sep 2025 21:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757713472; cv=none; b=gc/5MCdQxT2mqLbE5P5miyBgIa8I9gqSHnKSsrgRr7jibHvB9+bhR7LPXkpDFU4t2Qw6xIPIzivwOEEoOwczbOQ9CfIBqRV/uL7UIXDsXl63wimRPuS9g+g++sNxWC7Cnua/JB92m9FQ2f2af1H5mIs59lFWG0SIpbykugcaRKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757713472; c=relaxed/simple; bh=oSKfU+P7ccMg188II6EO2cJq+sduRk0IxK/pqog4cSU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=EPl7CZ3DKMCud5rEwr9KKxDswcn5/TGaYDSy2J6C27sv1DKaL0QtPAxKqToAtvqbvpd4RXJvPPz0H8RzvXn3RnGOg2eA9Sw4KZ8ZR2TKEma7i6IC0pJ5kGnsjqu/PPGAuw2cU/vkkQWxrhwmsqQcvHeAUe3XRFTrK7KHqY3OYJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bJ6I3O6S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bJ6I3O6S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83509C4CEF1; Fri, 12 Sep 2025 21:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757713471; bh=oSKfU+P7ccMg188II6EO2cJq+sduRk0IxK/pqog4cSU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bJ6I3O6StZuiXEUknMkPl1d+XBcHoYo8KEz0hmh0oJMDf7MhqDpzuxbw6otYgNdvz JUoafKn1e31LqhlISkZ1IQQvo20W6u8VnkDJhbEjZq7OJMpt2FSRjw/Yl3oEM4+MGl zJi+ZbrctAmToGrR+0+kYVvhWj9VNr4m1TTnmLaFSQFjQJcU7nQC8VBJld+w2K7JQ2 hdA8NkZHEjRX3CRgndAuVA12VfXC6o5sknSnGqtHy8dpKWt8tPgRSI15ldZl+Y3dPR Qn/IlGW3uuiqPMX3IKQFlaHmaALAhaAVaovvJOzJFbPAoPJGokI84V/j4pO+QH6w0h J8cxwUlIailTg== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1uxBZF-00000005pTe-1Lxi; Fri, 12 Sep 2025 21:44:29 +0000 Date: Fri, 12 Sep 2025 22:44:27 +0100 Message-ID: <87cy7vz6pw.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Oliver Upton , Joey Gouly , Suzuki K Poulose , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 5/6] KVM: arm64: Allow GCS to be enabled for guests In-Reply-To: <20250912-arm64-gcs-v16-5-6435e5ec37db@kernel.org> References: <20250912-arm64-gcs-v16-0-6435e5ec37db@kernel.org> <20250912-arm64-gcs-v16-5-6435e5ec37db@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 12 Sep 2025 10:25:31 +0100, Mark Brown wrote: > > Now that required functionality for GCS is in place expose > ID_AA64PFR1_EL1.GCS, allowing guests to be given the feature. > > Signed-off-by: Mark Brown > --- > arch/arm64/kvm/nested.c | 7 ++++--- > arch/arm64/kvm/sys_regs.c | 2 -- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c > index 153b3e11b115..d2d55e18c610 100644 > --- a/arch/arm64/kvm/nested.c > +++ b/arch/arm64/kvm/nested.c > @@ -1459,9 +1459,10 @@ u64 limit_nv_id_reg(struct kvm *kvm, u32 reg, u64 val) > > case SYS_ID_AA64PFR1_EL1: > /* Only support BTI, SSBS, CSV2_frac */ > - val &= (ID_AA64PFR1_EL1_BT | > - ID_AA64PFR1_EL1_SSBS | > - ID_AA64PFR1_EL1_CSV2_frac); > + val &= (ID_AA64PFR1_EL1_BT | > + ID_AA64PFR1_EL1_SSBS | > + ID_AA64PFR1_EL1_CSV2_frac | > + ID_AA64PFR1_EL1_GCS); How about updating the comment? M. -- Jazz isn't dead. It just smells funny.