From: Takashi Iwai <tiwai@suse.de>
To: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: lx_core: use int type to store negative error codes
Date: Thu, 28 Aug 2025 10:34:17 +0200 [thread overview]
Message-ID: <87cy8fg7zq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250828081312.393148-1-rongqianfeng@vivo.com>
On Thu, 28 Aug 2025 10:13:10 +0200,
Qianfeng Rong wrote:
>
> Change the 'ret' variable from u16 to int to store negative error codes or
> zero returned by lx_message_send_atomic().
>
> Storing the negative error codes in unsigned type, doesn't cause an issue
> at runtime but it's ugly as pants. Additionally, assigning negative error
> codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
> flag is enabled.
>
> No effect on runtime.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-08-28 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 8:13 [PATCH] ALSA: lx_core: use int type to store negative error codes Qianfeng Rong
2025-08-28 8:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cy8fg7zq.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rongqianfeng@vivo.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).