From: Esben Haabendal <esben@geanix.com>
To: "Alexander Stein" <alexander.stein@ew.tq-group.com>
Cc: "Dong Aisheng" <aisheng.dong@nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Jacky Bai" <ping.bai@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP S32 Linux Team" <s32@nxp.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled.
Date: Mon, 19 May 2025 08:55:57 +0200 [thread overview]
Message-ID: <87cyc5nl6q.fsf@geanix.com> (raw)
In-Reply-To: <20250514131342.755840-2-alexander.stein@ew.tq-group.com> (Alexander Stein's message of "Wed, 14 May 2025 15:13:40 +0200")
"Alexander Stein" <alexander.stein@ew.tq-group.com> writes:
> The pinctrl drivers are not enabled in defconfig. Instead of listing
> each driver in the defconfig, enable then by default if the platform/soc
> support is enabled as well.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v3:
> * None
>
> Changes in v2:
> * default pinctrl driver depending on SoC support
>
> The discussion at [1] resulted it is better to default SoC-specific pinctrl
> drivers to thei SoC support instead of adding to defconfig or selecting
> pinctrl.
>
> [1] https://lore.kernel.org/all/20250507124414.3088510-1-alexander.stein@ew.tq-group.com/
>
> drivers/pinctrl/freescale/Kconfig | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index d1610e2f21427..8d24decd3f074 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -22,6 +22,7 @@ config PINCTRL_IMX_SCU
> tristate
> depends on OF
> depends on IMX_SCU || COMPILE_TEST
> + default IMX_SCU
> select PINCTRL_IMX
>
> config PINCTRL_IMX1_CORE
> @@ -160,6 +161,7 @@ config PINCTRL_IMX8MM
> tristate "IMX8MM pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mm pinctrl driver
> @@ -168,6 +170,7 @@ config PINCTRL_IMX8MN
> tristate "IMX8MN pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mn pinctrl driver
> @@ -176,6 +179,7 @@ config PINCTRL_IMX8MP
> tristate "IMX8MP pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mp pinctrl driver
> @@ -184,6 +188,7 @@ config PINCTRL_IMX8MQ
> tristate "IMX8MQ pinctrl driver"
> depends on OF
> depends on SOC_IMX8M || COMPILE_TEST
> + default SOC_IMX8M
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8mq pinctrl driver
> @@ -192,6 +197,7 @@ config PINCTRL_IMX8QM
> tristate "IMX8QM pinctrl driver"
> depends on OF
> depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8qm pinctrl driver
> @@ -200,6 +206,7 @@ config PINCTRL_IMX8QXP
> tristate "IMX8QXP pinctrl driver"
> depends on OF
> depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8qxp pinctrl driver
> @@ -208,6 +215,7 @@ config PINCTRL_IMX8DXL
> tristate "IMX8DXL pinctrl driver"
> depends on OF
> depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX_SCU
> help
> Say Y here to enable the imx8dxl pinctrl driver
> @@ -216,6 +224,7 @@ config PINCTRL_IMX8ULP
> tristate "IMX8ULP pinctrl driver"
> depends on OF
> depends on ARCH_MXC || COMPILE_TEST
> + default ARCH_MXC
> select PINCTRL_IMX
> help
> Say Y here to enable the imx8ulp pinctrl driver
> @@ -240,6 +249,7 @@ config PINCTRL_IMX93
> tristate "IMX93 pinctrl driver"
> depends on OF
> depends on ARCH_MXC || COMPILE_TEST
> + default SOC_IMX9
> select PINCTRL_IMX
> help
> Say Y here to enable the imx93 pinctrl driver
> --
> 2.43.0
Acked-by: Esben Haabendal <esben@geanix.com>
next prev parent reply other threads:[~2025-05-19 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 13:13 [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Alexander Stein
2025-05-14 13:13 ` [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled Alexander Stein
2025-05-19 6:55 ` Esben Haabendal [this message]
2025-05-20 21:40 ` [PATCH v3 1/2] pinctrl: freescale: Depend imx-scu driver on OF Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyc5nl6q.fsf@geanix.com \
--to=esben@geanix.com \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox