From: Thomas Gleixner <tglx@linutronix.de>
To: Wen Xiong <wenxiong@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, gjoyce@linux.ibm.com,
linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] genirq/msi: Dynamic remove/add stroage adapter hits EEH
Date: Wed, 02 Apr 2025 10:33:05 +0200 [thread overview]
Message-ID: <87cydvvu7y.ffs@tglx> (raw)
In-Reply-To: <e83622773199665d39db5f724537d9dd@linux.ibm.com>
On Tue, Apr 01 2025 at 15:14, Wen Xiong wrote:
> On 2025-03-28 06:27, Thomas Gleixner wrote:
>
>> You are completely missing the point. This is not a problem restricted
>> to PCI/MSI interrupts.
>>
> Thanks for all suggestions! I will investigate more and check if we can
> fix it in device driver.
>
> Looks several device drivers in kernel use two kernel APIs to set/clean
> IRQ_NO_BALACING status for a given irq.
>
> irq_set_status_flags(irq, IRQ_NO_BALANCING);
> irq_clear_status_flags(irq, IRQ_NO_BALANCING);
>
> With these two APIs, device driver can decide if using kernel irq
> balance or setting irq affinity by driver itself?
>
> So we can set/clear IRQ_NO_BALANCING during reset.
That's not sufficient. You are papering over the symptom. I explained
you that affinity setting is not the only way to wreckage this.
But feel free to ignore me and apply your bandaid fix as you see fit.
Thanks,
tglx
prev parent reply other threads:[~2025-04-02 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 12:14 [PATCH 1/1] genirq/msi: Dynamic remove/add stroage adapter hits EEH wenxiong
2025-03-19 16:15 ` Thomas Gleixner
2025-03-20 2:58 ` Wen Xiong
2025-03-20 8:23 ` Thomas Gleixner
2025-03-20 8:48 ` Thomas Gleixner
2025-03-27 21:36 ` Wen Xiong
2025-03-28 11:27 ` Thomas Gleixner
2025-04-01 20:14 ` Wen Xiong
2025-04-02 8:33 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cydvvu7y.ffs@tglx \
--to=tglx@linutronix.de \
--cc=gjoyce@linux.ibm.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox