From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A7219AD8D for ; Mon, 20 Jan 2025 08:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737362748; cv=none; b=WBSB/oJCW/CjvKslOazC89FAfJbRNrIm4S0LdW/Bsb0C/C4mB+1TbsVAtALb2/2BBDKDRxpVpvHVdOWVZ7eNO8nsqWNicYJ9RHtE2yqxqRnsDOvUUyJCHE/tsx3dlIvWfqyjsWiPRJiRTWgQDD2il1zuKmXhGUQgBgp+qu7Rgc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737362748; c=relaxed/simple; bh=5KFj4LDT4CV9rj0sXKjTwQ+Y482gPuG82bNYyn2Uq3w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=F03kQHxWUpNvYeONl+w80kto76E/BnQ3384HT6I70MDyoKQ1YkxGHHK2rcmXLntcKEuSN7uW5+3opE/MFi3NQXjV3nWHOCni0ud5kyMC79zeLHPWxc73Rcw6LmkNyFpqu8ARwFKq1gVpgnZqRG4JHjbpIHQS9FvGJ5SJ7dQlQSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=fhiWiEOx; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=7xUzD//K; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="fhiWiEOx"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="7xUzD//K" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1737362744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MqmXBPGiuDVFQYnTa+479tv08C0YiGpazt4o47JVd0w=; b=fhiWiEOxr06FS5991FICyxhEhCyBMQVCXCAJe0a5vSI4STlgIPXzRicBjk0TLQz8jpnArd roy7/5waWaUacVY4oi2hhl+JPX/g1bmjdm3WDpim+NgsYRorPHzUhfLSUdDPJqc3upqUNp x8HLh1+DNLf1CwQgQbISgvfK9m26AwJKx1b8Wc96KoNaPCTR4vTqNON4WuIAjpXGotARIj lpW5L5rMDXHWnJ2ZIVF/rnqNPNx7X3Z1Z4/l1+yleKxlw3uBMFIqbWGplWcj2j/PTly2jl aD9R8ugHJqkiSl7+IU5S6nf7jU9zA8VWCCYaasm+mBOAXJP3cEoMqGqJZCdO/w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1737362744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MqmXBPGiuDVFQYnTa+479tv08C0YiGpazt4o47JVd0w=; b=7xUzD//K0xPBS085wgud+OxvOizOJj9bliYwJ+dQdSYPKvSUBFS+wpTXAp/rWH+b/USQqr QNgq0zY3XPRWI6Aw== To: Stefan Eichenberger Cc: andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, shivamurthy.shastri@linutronix.de, anna-maria@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] irqchip/irq-mvebu-icu: Fix irq_set_type for sei and nsr In-Reply-To: References: <20241217111623.92625-1-eichest@gmail.com> <87frlkcx2b.ffs@tglx> <87tt9ya2qy.ffs@tglx> Date: Mon, 20 Jan 2025 09:45:43 +0100 Message-ID: <87cyghan60.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Jan 17 2025 at 19:03, Stefan Eichenberger wrote: > It seems that irq_chip_set_type_parent is not failing. By adding some > debug messages to kernel/irq/manage.c I found that irqd_get_trigger_type > returns IRQF_TRIGGER_RISING even though it should return > IRQF_TRIGGER_HIGH according to the device tree. Maybe this was fixed > between 6.10 and 6.12 but I need to analyze that again in more detail. The trigger type is fixed up in mvebu_icu_irq_domain_translate(), but that should be the same with the new code in mvebu_icu_translate(). Can you instrument mvebu_icu_translate() and validate that it is 1) Invoked at all 2) The type fixup is done: if (msi_data->subset_data->icu_group == ICU_GRP_SEI) *type = IRQ_TYPE_EDGE_RISING; Thanks, tglx