From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81AA61C5F25 for ; Fri, 20 Dec 2024 13:14:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734700452; cv=none; b=FyECqVUksoIY8RUBPL2ZdkkMigUOJ/HNMGmFgEe0jc2lW5uU3GU9KG4XZvxqPZKHmuJ74OIYBtd7FSiHB+rGqCKVhGCe8m/IXqwuxctiQbjjgtRPEsXd7+41Nus9tZNpJL5kwNkTSCfkxFDXlxHPwlrY18a+ajyhZdnKGkJF9P0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734700452; c=relaxed/simple; bh=PiA8hOqtXj1pPSHrYHO1j4bpur57Ttvvv7ELYICDNmA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HYCHV00wb6Wit/enXWNo6OMZAhy0xC8fIoCjeSvN/j76e+li63rlLJW6JmT0Ss4q17b0TlBhsd3rltbqaWvgDo7rfKeStjabijkCwrHrcUF0EdgcVFiR6eC/BzToUNwXrQ0oxRVXifg47jZqz+iNvtJbjXR3TlQVhsqNwM3K8T4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=4sGKSz7S; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=HnR5LuvH; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="4sGKSz7S"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="HnR5LuvH" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1734700448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DewksccmaHKJ/b0RacNw+pSSHxlrrVXF6ODltDEjbms=; b=4sGKSz7SDoo4xFNS59//NI1MvVsyuWxgDhEqtUrNSQ4sqRIe69WX5D5UqTOZZVvvmL0nZC uh5ruNro8htI3UBR8RX3huXEjWdKqSecEd9S4jKHoMei/GNp0vxPEJwjys0QU7B1QhtreL O/eaOIwSrhg8fqL7/0fbrtqncvA5GKwN/2V8AVBCa1f7O0YeMydWxeiwwZHo8lz+OoNoDa lGd/FuDom+2SRTVpj00GDzV9zBRkb0i5qmb5PIaISgWIomRZM4m2t5//YGiJo41ocL8a9X Vsp4kVRXdgco5v8en0K1XoQaToSSLuE62g/r182Hb2ZYRzaRejGpoO3WuDofag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1734700448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DewksccmaHKJ/b0RacNw+pSSHxlrrVXF6ODltDEjbms=; b=HnR5LuvHSGzubuUx8JQQ0I09ffSf/jA2eo9iE2dR87AY8ho8bHUyizjxiNH1TlRV3SwTuK 74u1KoOQdB20zpBg== To: Frederic Weisbecker Cc: syzbot , anna-maria@linutronix.de, linux-kernel@vger.kernel.org, peterz@infradead.org, syzkaller-bugs@googlegroups.com, Eric Biederman , Oleg Nesterov Subject: Re: [PATCH] signal/posixtimers: Handle ignore/blocked sequences correctly In-Reply-To: References: <6761b16e.050a0220.29fcd0.006d.GAE@google.com> <87ikrf78xa.ffs@tglx> Date: Fri, 20 Dec 2024 14:14:07 +0100 Message-ID: <87cyhm7azk.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Dec 20 2024 at 14:06, Frederic Weisbecker wrote: > Le Thu, Dec 19, 2024 at 08:46:25PM +0100, Thomas Gleixner a =C3=A9crit : >> if (!list_empty(&q->list)) { >> /* >> - * If task group is exiting with the signal already pending, >> - * wait for __exit_signal() to do its job. Otherwise if >> - * ignored, it's not supposed to be queued. Try to survive. >> + * The signal was ignored and blocked. The timer >> + * expiry queued it because blocked signals are >> + * queued independent of the ignored state. >> + * >> + * The unblocking set SIGPENDING, but the signal >> + * was not yet dequeued from the pending list, >> + * which would have put it back on the ignore list. > > I must be missing something. I don't see dequeue_signal() checking if a s= ignal > is ignored upon delivery. Sorry, I meant get_signal() which is what the actual signal delivery path on exit to user space invokes. dequeue itself does not care.