From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 981287F6; Thu, 2 May 2024 00:03:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714608211; cv=none; b=qASusfLfIuwtCQMSWZzrrcfGvXieCX0rJ2YF6uz5TPSAj+BBuL5+ahSWempTx+UHIMAKdMdjhPKFm7kX0DLykPh0BtGKoAAL6f+Jgwn0Gad8D/3/tYGhwH7Zc7FLhQHVGKL8l+dp5BBWe+WEkUEK9rX3nmfPQqtX5zJ8tjH7XH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714608211; c=relaxed/simple; bh=1sKkjFU96N7WQ/Alcm0gt69fbHMFNm4H/4w/Y1PgO/w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=DAp1tqmf3A25MfsbZLvqTFbnDlGFC1qtajQfDCyJsrg+Mq0M/KkpBJkCwgqaT/9TuVGDkHkva0mKV/k1i9HvYS9+PaxWnae0k35+ufqZaYgVH2zfCxRnxp3BMrYEUvOBqZsMrNlVEjrBoOayAc9jJsUDpS5gRr0znpAGU6Vn6ZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kp8qZs/i; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=eJnJ1sG7; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kp8qZs/i"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="eJnJ1sG7" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1714608202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J4jzCGoAK5gYl8hpdgidkPo+bYHUWqSGYg+U6RVV820=; b=kp8qZs/i/NeO7qfmBU3pkT3RZ2CP7BAPeXs2WILS38escNUt21sBZ8FPt9ISkTZMM1JnR6 TgNk6LX4GPGmIA3aABXnoLlisukSiyZLBGOfl9+ZyZG8xd5tZi1u0ZfCtQYEsTt49JcA6D /j1jfLobwICqaaUuO0qwuXKQWrwKtycYAnQiFIY/OnKMOiAMmicgsLedA4tCzQ9pJVQg2q /jJlTqpyywNqqyW2lPvaXtcslXk0bDS5bYetRkwKaPskN/jBFFOuJ7iAFQkZe1yIPql96x xmckFM53fcT+6ESd0DZF6IQleqJCg5Gd/Yvdf5WZNgIOpKeiGq2fRauCZzbHAA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1714608202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J4jzCGoAK5gYl8hpdgidkPo+bYHUWqSGYg+U6RVV820=; b=eJnJ1sG70pSoKYDNmnIMoXYuvS14n1rytkredEJDGF5uaJOItsoLTMSzHeQnrN6W6lovD5 k+88/oJHU9x5qUBw== To: Herve Codina , Herve Codina , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 10/17] irqdomain: Add missing parameter descriptions in docs In-Reply-To: <20240430083730.134918-11-herve.codina@bootlin.com> References: <20240430083730.134918-1-herve.codina@bootlin.com> <20240430083730.134918-11-herve.codina@bootlin.com> Date: Thu, 02 May 2024 02:03:17 +0200 Message-ID: <87cyq5rsfu.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Apr 30 2024 at 10:37, Herve Codina wrote: > /** > * irq_domain_xlate_onecell() - Generic xlate for direct one cell bindings > + * @d: IRQ domain involved in the translation Please write out 'Interrupt domain' > + * @ctrlr: the DT node for the device whose interrupt we're translating Device tree node. And we are not translating anything. > + * @intspec: the interrupt specifier data from the DT > + * @intsize: the number of entries in @intspec > + * @out_hwirq: pointer at which to write the hwirq number Pointer to starage for the hardware interrupt number > + * @out_type: pointer at which to write the interrupt type ... Please align these in tabular fashion: + * @d: Interrupt domain involved in the translation + * @ctrlr: The device tree node for the device whose interrupt is translated + * @intspec: The interrupt specifier data from the device tree + * @intsize: The number of entries in @intspec + * @out_hwirq: Pointer to storage for the hardware interrupt number + * @out_type: Pointer to storage for the interrupt type > /** > * irq_domain_translate_onecell() - Generic translate for direct one cell > * bindings > + * @d: IRQ domain involved in the translation > + * @fwspec: FW interrupt specifier to translate Firmware interrupt specifier Thanks, tglx