From: Takashi Iwai <tiwai@suse.de>
To: Manuel Barrio Linares <mbarriolinares@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Geraldo Nascimento <geraldogabriel@gmail.com>,
dengxiang <dengxiang@nfschina.com>,
Jussi Laako <jussi@sonarnerd.net>,
Christos Skevis <xristos.thes@gmail.com>,
Alexander Tsoy <alexander@tsoy.me>,
Jeremie Knuesel <knuesel@gmail.com>,
WhaleChang <whalechang@google.com>, Sean Young <sean@mess.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: usb-audio: Add sampling rates support for Mbox3
Date: Tue, 30 Apr 2024 09:34:42 +0200 [thread overview]
Message-ID: <87cyq7nw19.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240429193522.10380-1-mbarriolinares@gmail.com>
On Mon, 29 Apr 2024 21:35:00 +0200,
Manuel Barrio Linares wrote:
>
> + set_rate = le32_to_cpu(buff4);
> + if (new_rate != set_rate)
Those two lines cause sparse warnings, unfortunately.
You can't assign int to __le32 type directly, and you can't compare
between those types directly, either.
That said, it should be rather like
if (new_rate != le32_to_cpu(buff4))
dev_warn(...);
You can check the sparse warning by yourself by passing C=1 argument
to make, too.
thanks,
Takashi
next prev parent reply other threads:[~2024-04-30 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 0:57 [PATCH] ALSA: usb-audio: Add sampling rates support for Mbox3 ManuLinares
2024-04-29 12:11 ` Takashi Iwai
2024-04-29 12:13 ` Takashi Iwai
2024-04-29 19:35 ` [PATCH v2] " Manuel Barrio Linares
2024-04-30 7:34 ` Takashi Iwai [this message]
2024-04-30 17:10 ` [PATCH v3] " Manuel Barrio Linares
2024-05-01 7:55 ` Takashi Iwai
2024-05-06 21:32 ` [PATCH v4] " Manuel Barrio Linares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyq7nw19.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexander@tsoy.me \
--cc=dengxiang@nfschina.com \
--cc=geraldogabriel@gmail.com \
--cc=jussi@sonarnerd.net \
--cc=knuesel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mbarriolinares@gmail.com \
--cc=perex@perex.cz \
--cc=sean@mess.org \
--cc=tiwai@suse.com \
--cc=whalechang@google.com \
--cc=xristos.thes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox