From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] wifi: nl80211: fix nl80211 UAPI kernel-doc
Date: Wed, 20 Mar 2024 11:18:04 +0200 [thread overview]
Message-ID: <87cyrp2reb.fsf@kernel.org> (raw)
In-Reply-To: <638df3bb659caef38480aa97277207b89c101344.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 20 Mar 2024 08:07:00 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Tue, 2024-03-19 at 11:26 -0700, Jeff Johnson wrote:
>> As part of my review of patches coming from the Qualcomm Innovation
>> Center I check to make sure that no checkpatch or kernel-doc issues
>> are introduced. An upcoming patch will propose a modification to
>> include/uapi/linux/nl80211.h. My review process flagged both
>> checkpatch and kernel-doc issues in the file, but these are
>> pre-existing issues. So this series fixes those pre-existing issues.
>>
>
> Thanks Jeff.
>
> Can you say what you're running for this? I've been running kernel-doc
> and builds with W=1 for a long time, and not seen issues. Is this
> perhaps checks from a newer kernel (we're currently on 6.8-rc1 for
> $reasons)?
FWIW I also check for kernel-doc warnings every time I push to wireless
or wireless-next and I don't see anything, so it's not kernel version
related. I think I'll add the Jeff's tests to my scripts, once he
provides them, so that we can catch these early.
Of course it would be even better to have patchwork tests for stuff like
this. Here's hoping we eventually implement those :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-03-20 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 18:26 [PATCH 0/3] wifi: nl80211: fix nl80211 UAPI kernel-doc Jeff Johnson
2024-03-19 18:26 ` [PATCH 1/3] wifi: nl80211: rename enum plink_actions Jeff Johnson
2024-03-19 18:26 ` [PATCH 2/3] wifi: nl80211: fix nl80211 uapi comment style issues Jeff Johnson
2024-03-19 18:26 ` [PATCH 3/3] wifi: nl80211: cleanup nl80211.h kernel-doc Jeff Johnson
2024-03-20 7:07 ` [PATCH 0/3] wifi: nl80211: fix nl80211 UAPI kernel-doc Johannes Berg
2024-03-20 9:18 ` Kalle Valo [this message]
2024-03-20 17:16 ` Jeff Johnson
2024-03-25 15:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyrp2reb.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox