From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E48CC288D7; Mon, 18 Mar 2024 09:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710753400; cv=none; b=TzmjzyQrSSN+gnOJzgZ4fR68FfOox8yYyiuUv3ZtP/MHqwCGRC+E7BHB+npvmEc1TJ/lbbPXl1iyTDd8iiViHV0Y9IhFd80/fcMv+Mu9GA9uiCQTtITqj5cObN4GUoPKgb1hlC6jCTrSknF3zGqZMra2UA31+I1XPBo3wZx7XEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710753400; c=relaxed/simple; bh=rd/N8eECG5DqNJF9AND8kYYBBUUlV3bfuFIwcupqOdA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=rrr6FKrM4gSaBtlQ7VHewOoXtRMSg8Fd6OpNP4TieP3J7ySZq2oSvmcHCmzPgEht8ZL7CV/FhGnhfv7rXNXmvG5AKTU1F3Pkr0fN9b7TzQF6vlF8dTALelXPF2iSfYMPuKMEZtXQuQX9U0vrnqCLeo/TjrnPWdvEGPgQ1P2KxrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KFcSgqDz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KFcSgqDz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA362C433C7; Mon, 18 Mar 2024 09:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710753399; bh=rd/N8eECG5DqNJF9AND8kYYBBUUlV3bfuFIwcupqOdA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KFcSgqDz8ypxxpPi2NmlEEqRNhjdoDf4LLddQVSzWr++KQtgUew9Yx12fEKvxcwty KGS0u9zp/uIWPhgSudrn83Ymd6OlowAN6xZzSLvrZV/FBNEZmZ1s3n3DPAU3z+ICEZ SiX+CacY5ZDCqeOMrzFDUX+hcfSiJMcUSbpBhkCtAgFZ6eJbp9UMIGWonFiP0ioaKR dPqbxyjku321Jj24aeQBP+lGazSW+Tswvsg1pN/DV+WW+3EA7fJ9UO+OKh8t55lYrM IbuJlpPAZBjyi53kSgzaWjWog6TaZA0wYVaZ28HmPuGm+7gaSn7BEC2NTmmvn71FNP jJgh3zMY4hctw== From: Kalle Valo To: Li Zhijian Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 3/3] wifi: ti: Convert sprintf/snprintf to sysfs_emit References: <20240315055211.1347548-1-lizhijian@fujitsu.com> <20240315055211.1347548-3-lizhijian@fujitsu.com> Date: Mon, 18 Mar 2024 11:16:36 +0200 In-Reply-To: <20240315055211.1347548-3-lizhijian@fujitsu.com> (Li Zhijian's message of "Fri, 15 Mar 2024 13:52:11 +0800") Message-ID: <87cyrrew7f.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Li Zhijian writes: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > > sprintf() will be converted as weel if they have. > > Generally, this patch is generated by > make coccicheck M= MODE=patch \ > COCCI=scripts/coccinelle/api/device_attr_show.cocci > > No functional change intended > > CC: Kalle Valo > CC: linux-wireless@vger.kernel.org > Signed-off-by: Li Zhijian > --- > V2: subject updated > > This is a part of the work "Fix coccicheck device_attr_show warnings"[1] > Split them per subsystem so that the maintainer can review it easily > [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@fujitsu.com/ > Signed-off-by: Li Zhijian Please resubmit the whole patchset as v3. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#resubmit_the_whole_patchset -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches