From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@linux.intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mtrr: Check if fixed MTRRs exist before saving them
Date: Wed, 10 Jan 2024 15:20:50 +0100 [thread overview]
Message-ID: <87cyu9jmm5.ffs@tglx> (raw)
In-Reply-To: <ZZ4b6aq6s_GbpbcN@tassilo>
On Tue, Jan 09 2024 at 20:24, Andi Kleen wrote:
> On Tue, Jan 09, 2024 at 08:06:26PM +0100, Thomas Gleixner wrote:
>> On Fri, Jan 05 2024 at 08:37, Andi Kleen wrote:
>> > This one place forgot to check the fixed capability.
>>
>> What's the consequence of that missing chec
>
> You get a WARN_ON for a WRMSR failing if you don't have the MSR.
>
>> and shouldn't this have a Fixes tag?
>
> It's more an ancient bug back dating back to my tenure in 2007, but here it is:
>
> Fixes: 2b1f6278d77c ("[PATCH] x86: Save the MTRRs of the BSP before")
Care to send a V2 with a less meager changelog?
prev parent reply other threads:[~2024-01-10 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 16:37 [PATCH] x86/mtrr: Check if fixed MTRRs exist before saving them Andi Kleen
2024-01-09 19:06 ` Thomas Gleixner
2024-01-10 4:24 ` Andi Kleen
2024-01-10 14:20 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyu9jmm5.ffs@tglx \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox