From: Kalle Valo <kvalo@kernel.org>
To: Mathias Krause <minipli@grsecurity.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH] PCI: Remove unused 'node' member from struct pci_driver
Date: Wed, 20 Dec 2023 16:11:37 +0200 [thread overview]
Message-ID: <87cyv12cbq.fsf@kernel.org> (raw)
In-Reply-To: <20231220133505.8798-1-minipli@grsecurity.net> (Mathias Krause's message of "Wed, 20 Dec 2023 14:35:05 +0100")
Mathias Krause <minipli@grsecurity.net> writes:
> Remove the unused 'node' member. It got replaced by device_driver
> chaining more than 20 years ago in commit 4b4a837f2b57 ("PCI: start to
> use common fields of struct device_driver more...") of the history.git
> tree.
>
> Signed-off-by: Mathias Krause <minipli@grsecurity.net>
> ---
> There is only one "user" that makes use of the 'node' member, which is
> the brcm80211 driver. However, its "use" is clearly wrong (a list head
> cannot be initialized this way) and, obviously, not needed.
>
> If netdev folks instead want to split this off into a separate commit, I
> can do that. However, I don't expect any cross-tree conflicts regarding
> this change.
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 -
> include/linux/pci.h | 2 --
> 2 files changed, 3 deletions(-)
No need to split anything, feel free to take this via PCI tree:
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-12-20 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 13:35 [PATCH] PCI: Remove unused 'node' member from struct pci_driver Mathias Krause
2023-12-20 14:11 ` Kalle Valo [this message]
2023-12-27 0:01 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyv12cbq.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=arend.vanspriel@broadcom.com \
--cc=bhelgaas@google.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=minipli@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox