public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Todd Brandt <todd.e.brandt@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] printk: Reduce unnecessary wait times by pr_flush()
Date: Tue, 10 Oct 2023 13:44:38 +0206	[thread overview]
Message-ID: <87cyxmso5d.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <ZSUPBiTXY486H1FV@alley>

On 2023-10-10, Petr Mladek <pmladek@suse.com> wrote:
>> This is an updated version of the patch
>> https://lore.kernel.org/r/20230929113233.863824-1-john.ogness@linutronix.de
>> 
>> Changes since v1:
>> 
>>   + Split reduction of the pooling time into separate patch.
>>   + Use jiffies to count the real sleeping time.
>> 
>> Note that my original POC counted jiffies spent in the entire cycle.
>> It would count also the time spent by console_lock() and by flushing
>> the legacy consoles in console_unlock().
>> 
>> The current version counts only the time spent by msleep(1) aka
>> the pooling interval.
>> 
>> 
>> John Ogness (1):
>>   printk: flush consoles before checking progress
>> 
>> Petr Mladek (1):
>>   printk: Reduce pr_flush() pooling time
>
> JFYI, the patchset has been committed into printk/linux.git,
> branch rework/misc-cleanups.
>
> I am going to push it in the next merge window for 6.7.
> IMHO, the issue is not critical and we are already at 6.6-rc5.

It is a real regression. I think it is important that it goes into
6.6. At least the first patch is simple enough and fixes the regression.

John

  reply	other threads:[~2023-10-10 11:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06  8:21 [PATCH v2 0/2] printk: Reduce unnecessary wait times by pr_flush() Petr Mladek
2023-10-06  8:21 ` [PATCH v2 1/2] printk: flush consoles before checking progress Petr Mladek
2023-10-06  8:21 ` [PATCH v2 2/2] printk: Reduce pr_flush() pooling time Petr Mladek
2023-10-06 10:12   ` John Ogness
2023-10-10  8:44 ` [PATCH v2 0/2] printk: Reduce unnecessary wait times by pr_flush() Petr Mladek
2023-10-10 11:38   ` John Ogness [this message]
2023-10-11 12:10     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyxmso5d.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    --cc=todd.e.brandt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox