From: Takashi Iwai <tiwai@suse.de>
To: Fabian Vogt <fabian@ritter-vogt.de>
Cc: SungHwan Jung <onenowy@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
perex@perex.cz
Subject: Re: [PATCH v2] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx
Date: Fri, 25 Aug 2023 09:49:52 +0200 [thread overview]
Message-ID: <87cyzb8stb.wl-tiwai@suse.de> (raw)
In-Reply-To: <2693091.mvXUDI8C0e@fabians-envy>
On Thu, 24 Aug 2023 20:39:48 +0200,
Fabian Vogt wrote:
>
> The LED for the mic mute button is controlled by GPIO2.
> The mute button LED is slightly more complex, it's controlled by two bits
> in coeff 0x0b.
>
> Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de>
> ---
> Changes since v1:
> Rebased on 03b0563c2f35. I've got this laptop for almost two years now and
> two days ago decided to dig into the issue with mute LEDs. What amazing timing
> that someone else made the exact same fixup for a different model just hours
> before I submit...
> Renamed quirk to ..._LEDS to distinguish it from the similar quirk which
> handles only one of the mute LEDs.
Applied now. Thanks.
BTW, at the next time you post a v2 patch, it's better to start a new
thread instead of hanging to the old thread.
Takashi
prev parent reply other threads:[~2023-08-25 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 15:57 [PATCH] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx Fabian Vogt
2023-08-24 17:37 ` SungHwan Jung
2023-08-24 17:44 ` Takashi Iwai
2023-08-24 18:39 ` [PATCH v2] " Fabian Vogt
2023-08-25 7:49 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyzb8stb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=fabian@ritter-vogt.de \
--cc=linux-kernel@vger.kernel.org \
--cc=onenowy@gmail.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox