From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Marco Elver <elver@google.com>,
syzbot <syzbot+3b14b2ed9b3d06dcaa07@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Jacob Keller <jacob.e.keller@intel.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] posix-cpu-timers: Implement the missing timer_wait_running callback
Date: Wed, 19 Apr 2023 09:33:20 +0200 [thread overview]
Message-ID: <87cz40498f.ffs@tglx> (raw)
In-Reply-To: <ZD7JAppWQCoBEBgN@localhost.localdomain>
On Tue, Apr 18 2023 at 18:44, Frederic Weisbecker wrote:
> Le Mon, Apr 17, 2023 at 03:37:55PM +0200, Thomas Gleixner a écrit :
>> struct cpu_timer {
>> struct timerqueue_node node;
>> @@ -72,6 +74,7 @@ struct cpu_timer {
>> struct pid *pid;
>> struct list_head elist;
>> int firing;
>> + struct task_struct *handling;
>
> I guess it can be made __rcu
Indeed.
>> if (likely(cpu_firing >= 0))
>> cpu_timer_fire(timer);
>> + /* See posix_cpu_timer_wait_running() */
>> + WRITE_ONCE(timer->it.cpu.handling, NULL);
>
> And rcu_assign_pointer()
I fix that up on the fly.
> Aside the boring details:
>
> Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Thanks for going through this!
next prev parent reply other threads:[~2023-04-19 7:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 17:07 WARNING in timer_wait_running syzbot
2023-04-05 21:07 ` Marco Elver
2023-04-05 22:19 ` Frederic Weisbecker
2023-04-06 19:37 ` Thomas Gleixner
2023-04-07 8:44 ` Thomas Gleixner
2023-04-07 11:50 ` Frederic Weisbecker
2023-04-07 17:47 ` Thomas Gleixner
2023-04-07 18:36 ` Frederic Weisbecker
2023-04-07 19:27 ` Thomas Gleixner
2023-04-07 21:00 ` Frederic Weisbecker
2023-04-11 14:31 ` Marco Elver
2023-04-17 13:37 ` [PATCH] posix-cpu-timers: Implement the missing timer_wait_running callback Thomas Gleixner
2023-04-17 15:34 ` Sebastian Andrzej Siewior
2023-04-18 6:00 ` Marco Elver
2023-04-18 16:44 ` Frederic Weisbecker
2023-04-19 7:33 ` Thomas Gleixner [this message]
2023-04-19 8:33 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2023-04-20 7:51 ` tip-bot2 for Thomas Gleixner
2023-04-21 13:43 ` tip-bot2 for Thomas Gleixner
[not found] ` <20230407134620.1034-1-hdanton@sina.com>
2023-04-07 14:49 ` WARNING in timer_wait_running Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz40498f.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=elver@google.com \
--cc=frederic@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=syzbot+3b14b2ed9b3d06dcaa07@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).