Re: [PATCH v4 3/4] fat: add renameat2 RENAME_EXCHANGE flag support

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Javier Martinez Canillas <javierm@redhat.com> writes:

> On 6/8/22 16:33, OGAWA Hirofumi wrote:
>> Javier Martinez Canillas <javierm@redhat.com> writes:
>> 
>>> +	/* update ".." directory entry info */
>>> +	if (old_dotdot_de) {
>>> +		err = vfat_update_dotdot_de(new_dir, old_inode, old_dotdot_bh,
>>> +					    old_dotdot_de);
>>> +		if (err)
>>> +			goto error_old_dotdot;
>>> +		drop_nlink(old_dir);
>>> +		inc_nlink(new_dir);
>>> +	}
>>> +
>>> +	if (new_dotdot_de) {
>>> +		err = vfat_update_dotdot_de(old_dir, new_inode, new_dotdot_bh,
>>> +					    new_dotdot_de);
>>> +		if (err)
>>> +			goto error_new_dotdot;
>>> +		drop_nlink(new_dir);
>>> +		inc_nlink(old_dir);
>>> +	}
>> 
>> Probably, we should change the nlink only if both of dotdot update are
>> succeed and different file type. Otherwise, we would have to revert the
>> nlink change on error path (and can remove unnecessary update as bonus).
>> 
>
> Agreed. I'll wait a few days before posting v5 in case you have more
> comments on the other patches.

Ok. I have no comment other than this at least for now (reviewed all
patches). If I found more on re-review I will send email.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>