Re: [PATCHv2 20/29] x86/tdx: Get page shared bit info from the TDX module

Thomas Gleixner
2022-02-02T00:14:07Z

On Mon, Jan 24 2022 at 18:02, Kirill A. Shutemov wrote:
> +static void tdx_get_info(void)
> +{
> + struct tdx_module_output out;
> + u64 ret;
> +
> + /*
> + * TDINFO TDX module call is used to get the TD execution environment
> + * information like GPA width, number of available vcpus, debug mode
> + * information, etc. More details about the ABI can be found in TDX
> + * Guest-Host-Communication Interface (GHCI), sec 2.4.2 TDCALL
> + * [TDG.VP.INFO].
> + */
> + ret = __tdx_module_call(TDX_GET_INFO, 0, 0, 0, 0, &out);
> +
> + /* Non zero return value indicates buggy TDX module, so panic */

Can you please get rid of these useless comments all over the place. The
panic() message tells the same story. Please document the non-obvious
things.

Thanks,

tglx