From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A840EC433F5 for ; Mon, 25 Oct 2021 10:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E69361050 for ; Mon, 25 Oct 2021 10:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232924AbhJYKg2 (ORCPT ); Mon, 25 Oct 2021 06:36:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:59214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232875AbhJYKg1 (ORCPT ); Mon, 25 Oct 2021 06:36:27 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E6256108B; Mon, 25 Oct 2021 10:34:05 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mexIp-001KzI-JK; Mon, 25 Oct 2021 11:34:03 +0100 Date: Mon, 25 Oct 2021 11:34:03 +0100 Message-ID: <87czntbdgk.wl-maz@kernel.org> From: Marc Zyngier To: guoren@kernel.org Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, Guo Ren , Marc Zyngier Subject: Re: [PATCH] irqchip/irq-csky-mpintc: Fixup mask/unmask un-implementation In-Reply-To: <20211025091219.3665576-1-guoren@kernel.org> References: <20211025091219.3665576-1-guoren@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: guoren@kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, guoren@linux.alibaba.com, marc.zyngier@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Oct 2021 10:12:19 +0100, guoren@kernel.org wrote: > > From: Guo Ren > > The mask/unmask must be implemented, and enable/disable supplement > them if the HW requires something different at startup time. When > irq source is disabled by mask, mpintc could complete irq normally. > > So just replace the with mask/unmask function. > > Tested-by: Guo Ren This only makes sense if tested by a third party. It is assumed that the author of a patch has tested it. > Signed-off-by: Guo Ren > Cc: Marc Zyngier This hasn't been my email address for over two years now. I'm sure my ex manager is happy to hear from you, but I doubt he'll bother replying. > --- > drivers/irqchip/irq-csky-mpintc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-csky-mpintc.c b/drivers/irqchip/irq-csky-mpintc.c > index a1534edef7fa..f169600dbde6 100644 > --- a/drivers/irqchip/irq-csky-mpintc.c > +++ b/drivers/irqchip/irq-csky-mpintc.c > @@ -164,8 +164,8 @@ static int csky_irq_set_affinity(struct irq_data *d, > static struct irq_chip csky_irq_chip = { > .name = "C-SKY SMP Intc", > .irq_eoi = csky_mpintc_eoi, > - .irq_enable = csky_mpintc_enable, > - .irq_disable = csky_mpintc_disable, > + .irq_unmask = csky_mpintc_enable, > + .irq_mask = csky_mpintc_disable, > .irq_set_type = csky_mpintc_set_type, > #ifdef CONFIG_SMP > .irq_set_affinity = csky_irq_set_affinity, Please rename the functions to match the fields they are assigned to. Thanks, M. -- Without deviation from the norm, progress is not possible.