From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13600C433E9 for ; Wed, 17 Mar 2021 14:03:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D94A064F67 for ; Wed, 17 Mar 2021 14:03:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231617AbhCQODA (ORCPT ); Wed, 17 Mar 2021 10:03:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:49008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbhCQOCq (ORCPT ); Wed, 17 Mar 2021 10:02:46 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8482664F5E; Wed, 17 Mar 2021 14:02:45 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lMWl1-002DhL-Fn; Wed, 17 Mar 2021 14:02:43 +0000 Date: Wed, 17 Mar 2021 14:02:42 +0000 Message-ID: <87czvxj2t9.wl-maz@kernel.org> From: Marc Zyngier To: Maulik Shah Cc: swboyd@chromium.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, dianders@chromium.org, rnayak@codeaurora.org, lsrao@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8350: Remove second reg from pdc In-Reply-To: References: <1615958996-31807-1-git-send-email-mkshah@codeaurora.org> <87k0q6i1g5.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mkshah@codeaurora.org, swboyd@chromium.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, dianders@chromium.org, rnayak@codeaurora.org, lsrao@codeaurora.org, devicetree@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Mar 2021 09:48:09 +0000, Maulik Shah wrote: > > Hi Marc, > > On 3/17/2021 2:47 PM, Marc Zyngier wrote: > > On Wed, 17 Mar 2021 05:29:54 +0000, > > Maulik Shah wrote: > >> PDC interrupt controller driver do not use second reg. Remove it. > > This is a DT file, not a driver. What the driver does is irrelevant. > > > > The real question is: what does this range do? > > > > Thanks, > > > > M. > > This is to set interrupt type in SPI config for which there was a > change [1] but has not gone in for upstream PDC driver. > > The second reg is not used in upstream PDC driver, probably when > posting downstream DT changes for sm8350/sm8250 it was carried in > device node as is. > > As its not mentioned in bindigs as well, dtbs_check reports it as > additional reg when converted to yaml. Then I'd rather you provide accurate documentation in the binding rather than changing the DT files. Other operating systems may use it, and it isn't unlikely that Linux could use the feature at some point. Thanks, M. -- Without deviation from the norm, progress is not possible.