From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A57E5C433E0 for ; Thu, 18 Feb 2021 10:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60F1964ECA for ; Thu, 18 Feb 2021 10:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbhBRKQz (ORCPT ); Thu, 18 Feb 2021 05:16:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:47946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbhBRJJd (ORCPT ); Thu, 18 Feb 2021 04:09:33 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0E386146D; Thu, 18 Feb 2021 09:08:14 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lCfIC-00EjTe-HJ; Thu, 18 Feb 2021 09:08:12 +0000 Date: Thu, 18 Feb 2021 09:08:12 +0000 Message-ID: <87czwxpwub.wl-maz@kernel.org> From: Marc Zyngier To: Greg KH Cc: Michael Walle , linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain In-Reply-To: References: <20210217195717.13727-1-michael@walle.cc> <4e4d0479b935e60a53f75ef534086476@kernel.org> <5c527bfb6f3dfe31b5c25f29418306c6@walle.cc> <87czwys6s1.wl-maz@kernel.org> <8b4de9eae773a43b38f42c8ab6d9d23c@walle.cc> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: gregkh@linuxfoundation.org, michael@walle.cc, linux-kernel@vger.kernel.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Feb 2021 08:52:53 +0000, Greg KH wrote: [...] > Ok, how about this: > > > diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c > index 2fcf66473436..86c7f0489620 100644 > --- a/fs/debugfs/inode.c > +++ b/fs/debugfs/inode.c > @@ -297,7 +297,7 @@ struct dentry *debugfs_lookup(const char *name, struct dentry *parent) > { > struct dentry *dentry; > > - if (IS_ERR(parent)) > + if (!debugfs_initialized() || IS_ERR_OR_NULL(name) || IS_ERR(parent)) > return NULL; > > if (!parent) > @@ -318,6 +318,9 @@ static struct dentry *start_creating(const char *name, struct dentry *parent) > if (!(debugfs_allow & DEBUGFS_ALLOW_API)) > return ERR_PTR(-EPERM); > > + if (!debugfs_initialized()) > + return ERR_PTR(-ENOENT); > + > pr_debug("creating file '%s'\n", name); > > if (IS_ERR(parent)) > That one boots correctly in a guest. Thanks, M. -- Without deviation from the norm, progress is not possible.