From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: David Gow <davidgow@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fat: Add KUnit tests for checksums and timestamps
Date: Tue, 20 Oct 2020 15:51:35 +0900 [thread overview]
Message-ID: <87d01die4o.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20201020055856.1270482-1-davidgow@google.com> (David Gow's message of "Mon, 19 Oct 2020 22:58:56 -0700")
David Gow <davidgow@google.com> writes:
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index f1b2a1fc2a6a..445ad3542e74 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -229,6 +229,7 @@ void fat_time_fat2unix(struct msdos_sb_info *sbi, struct timespec64 *ts,
> ts->tv_nsec = 0;
> }
> }
> +EXPORT_SYMBOL_GPL(fat_time_fat2unix);
Hm, can this export only if FAT_KUNIT_TEST is builtin or module (maybe
#if IS_ENABLED(...))? And #if will also be worked as the comment too.
>
> /* Convert linear UNIX date to a FAT time/date pair. */
> void fat_time_unix2fat(struct msdos_sb_info *sbi, struct timespec64 *ts,
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2020-10-20 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 5:58 [PATCH v2] fat: Add KUnit tests for checksums and timestamps David Gow
2020-10-20 6:51 ` OGAWA Hirofumi [this message]
2020-10-21 3:50 ` David Gow
2020-10-21 5:19 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d01die4o.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox